Skip to content

fix: use in-memory PGP signing instead of writing key to tmp file - #318

Merged
didiergarcia merged 1 commit into
mainfrom
fix/in-memory-pgp-signing
Jul 28, 2026
Merged

fix: use in-memory PGP signing instead of writing key to tmp file#318
didiergarcia merged 1 commit into
mainfrom
fix/in-memory-pgp-signing

Conversation

@didiergarcia

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the approach of writing the base64-decoded PGP key to a tmp file (tmp/key.pgp) with setting it as an in-memory string property (signing.key)
  • mvn-publish.gradle already uses useInMemoryPgpKeys() which reads from signing.key — the old file-based approach was incompatible with it
  • Removes the tmp directory creation side effect during builds

Test plan

  • Verified working end-to-end: the 1.26.0 release was published to Maven Central successfully with this change in place

@didiergarcia
didiergarcia merged commit a2df3ce into main Jul 28, 2026
9 checks passed
@didiergarcia
didiergarcia deleted the fix/in-memory-pgp-signing branch July 28, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants