Skip to content

Commit 9ae1570

Browse files
abueideclaude
abueide
and
claude
committed
refactor: simplify devbox includes to only react-native plugin
- Remove explicit android/ios plugin includes - Use mobile-devtools branch with GitHub URL includes fix - React-native plugin now properly includes android/ios via GitHub URLs - Depends on segment-integrations/mobile-devtools#10 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent c013dc1 commit 9ae1570

4 files changed

Lines changed: 20 additions & 62 deletions

File tree

‎examples/E2E-compat/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ devbox run test:e2e:android
3636
- `devbox run install` - Install Node dependencies
3737
- `devbox run install:pods` - Install iOS CocoaPods
3838
- `devbox run build:android` - Build Android app
39-
- `devbox run build:ios` - Build iOS app
39+
- `devbox run build:ios` - Build iOS app
4040
- `devbox run test:e2e:android` - Run Android E2E tests
4141
- `devbox run test:e2e:ios` - Run iOS E2E tests
4242
- `devbox run start:emu` - Start Android emulator

‎examples/E2E-compat/devbox.json‎

Lines changed: 9 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
{
22
"include": [
3-
"github:segment-integrations/mobile-devtools?dir=plugins/android",
4-
"github:segment-integrations/mobile-devtools?dir=plugins/ios",
5-
"github:segment-integrations/mobile-devtools?dir=plugins/react-native"
6-
],
7-
"packages": [
8-
"nodejs@20",
9-
"watchman@latest",
10-
"jdk17@latest",
11-
"gradle@latest"
3+
"github:segment-integrations/mobile-devtools?dir=plugins/react-native&ref=fix/use-github-urls-for-plugin-includes"
124
],
5+
"packages": ["nodejs@20", "watchman@latest", "jdk17@latest", "gradle@latest"],
136
"env": {
147
"IOS_APP_SCHEME": "AnalyticsReactNativeE2E",
158
"IOS_APP_BUNDLE_ID": "com.analyticsreactnativeexample",
@@ -20,12 +13,8 @@
2013
},
2114
"shell": {
2215
"scripts": {
23-
"install": [
24-
"yarn install"
25-
],
26-
"install:pods": [
27-
"cd ios && pod install --repo-update && cd .."
28-
],
16+
"install": ["yarn install"],
17+
"install:pods": ["cd ios && pod install --repo-update && cd .."],
2918
"build:android": [
3019
"devbox run install",
3120
"cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release && cd .."
@@ -43,24 +32,14 @@
4332
"devbox run build:ios",
4433
"yarn detox test --configuration ios.sim.release"
4534
],
46-
"start:metro": [
47-
"metro.sh start ${1:-default}"
48-
],
49-
"stop:metro": [
50-
"metro.sh stop ${1:-default}"
51-
],
52-
"start:sim": [
53-
"ios.sh simulator start ${1:-${IOS_DEFAULT_DEVICE:-max}}"
54-
],
55-
"stop:sim": [
56-
"ios.sh simulator stop"
57-
],
35+
"start:metro": ["metro.sh start ${1:-default}"],
36+
"stop:metro": ["metro.sh stop ${1:-default}"],
37+
"start:sim": ["ios.sh simulator start ${1:-${IOS_DEFAULT_DEVICE:-max}}"],
38+
"stop:sim": ["ios.sh simulator stop"],
5839
"start:emu": [
5940
"android.sh emulator start ${1:-${ANDROID_DEFAULT_DEVICE:-max}}"
6041
],
61-
"stop:emu": [
62-
"android.sh emulator stop"
63-
]
42+
"stop:emu": ["android.sh emulator stop"]
6443
}
6544
}
6645
}

‎examples/E2E-latest/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ devbox run test:e2e:android
3636
- `devbox run install` - Install Node dependencies
3737
- `devbox run install:pods` - Install iOS CocoaPods
3838
- `devbox run build:android` - Build Android app
39-
- `devbox run build:ios` - Build iOS app
39+
- `devbox run build:ios` - Build iOS app
4040
- `devbox run test:e2e:android` - Run Android E2E tests
4141
- `devbox run test:e2e:ios` - Run iOS E2E tests
4242
- `devbox run start:emu` - Start Android emulator

‎examples/E2E-latest/devbox.json‎

Lines changed: 9 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
{
22
"include": [
3-
"github:segment-integrations/mobile-devtools?dir=plugins/android",
4-
"github:segment-integrations/mobile-devtools?dir=plugins/ios",
5-
"github:segment-integrations/mobile-devtools?dir=plugins/react-native"
6-
],
7-
"packages": [
8-
"nodejs@20",
9-
"watchman@latest",
10-
"jdk17@latest",
11-
"gradle@latest"
3+
"github:segment-integrations/mobile-devtools?dir=plugins/react-native&ref=fix/use-github-urls-for-plugin-includes"
124
],
5+
"packages": ["nodejs@20", "watchman@latest", "jdk17@latest", "gradle@latest"],
136
"env": {
147
"IOS_APP_SCHEME": "AnalyticsReactNativeE2E",
158
"IOS_APP_BUNDLE_ID": "com.analyticsreactnativeexample",
@@ -20,12 +13,8 @@
2013
},
2114
"shell": {
2215
"scripts": {
23-
"install": [
24-
"yarn install"
25-
],
26-
"install:pods": [
27-
"cd ios && pod install --repo-update && cd .."
28-
],
16+
"install": ["yarn install"],
17+
"install:pods": ["cd ios && pod install --repo-update && cd .."],
2918
"build:android": [
3019
"devbox run install",
3120
"cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release && cd .."
@@ -43,24 +32,14 @@
4332
"devbox run build:ios",
4433
"yarn detox test --configuration ios.sim.release"
4534
],
46-
"start:metro": [
47-
"metro.sh start ${1:-default}"
48-
],
49-
"stop:metro": [
50-
"metro.sh stop ${1:-default}"
51-
],
52-
"start:sim": [
53-
"ios.sh simulator start ${1:-${IOS_DEFAULT_DEVICE:-max}}"
54-
],
55-
"stop:sim": [
56-
"ios.sh simulator stop"
57-
],
35+
"start:metro": ["metro.sh start ${1:-default}"],
36+
"stop:metro": ["metro.sh stop ${1:-default}"],
37+
"start:sim": ["ios.sh simulator start ${1:-${IOS_DEFAULT_DEVICE:-max}}"],
38+
"stop:sim": ["ios.sh simulator stop"],
5839
"start:emu": [
5940
"android.sh emulator start ${1:-${ANDROID_DEFAULT_DEVICE:-max}}"
6041
],
61-
"stop:emu": [
62-
"android.sh emulator stop"
63-
]
42+
"stop:emu": ["android.sh emulator stop"]
6443
}
6544
}
6645
}

0 commit comments

Comments
 (0)