fix: fix bundle unbundled logic (#521)

alanjcharles · Alan Charles · web-flow · commit 9e080b13d072 · 2022-04-29T14:31:08.000-06:00
Co-authored-by: Alan Charles &lt;alancharles@Alans-MacBook-Pro-2.local&gt;
diff --git a/packages/core/src/plugins/DestinationMetadataEnrichment.ts b/packages/core/src/plugins/DestinationMetadataEnrichment.ts
@@ -29,7 +29,7 @@ export class DestinationMetadataEnrichment extends UtilityPlugin {
         continue;
       }
 
-      if (key in pluginSettings) {
+      if (Object.keys(pluginSettings).includes(key)) {
         bundled.push(key);
       }
     }
@@ -41,7 +41,7 @@ export class DestinationMetadataEnrichment extends UtilityPlugin {
       segmentInfo.unbundledIntegrations ?? [];
 
     for (const integration of unbundledIntegrations) {
-      if (!(integration in bundled)) {
+      if (!bundled.includes(integration)) {
         unbundled.push(integration);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export class DestinationMetadataEnrichment extends UtilityPlugin {`
`29`	`29`	`continue;`
`30`	`30`	`}`
`31`	`31`
`32`		`- if (key in pluginSettings) {`
	`32`	`+ if (Object.keys(pluginSettings).includes(key)) {`
`33`	`33`	`bundled.push(key);`
`34`	`34`	`}`
`35`	`35`	`}`
`@@ -41,7 +41,7 @@ export class DestinationMetadataEnrichment extends UtilityPlugin {`
`41`	`41`	`segmentInfo.unbundledIntegrations ?? [];`
`42`	`42`
`43`	`43`	`for (const integration of unbundledIntegrations) {`
`44`		`- if (!(integration in bundled)) {`
	`44`	`+ if (!bundled.includes(integration)) {`
`45`	`45`	`unbundled.push(integration);`
`46`	`46`	`}`
`47`	`47`	`}`