fix(deps): switch react-native-get-random-values to optional#1298
Open
SYoder1 wants to merge 1 commit into
Open
fix(deps): switch react-native-get-random-values to optional#1298SYoder1 wants to merge 1 commit into
SYoder1 wants to merge 1 commit into
Conversation
Author
|
@abueide I know you just update the peer version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-native-get-random-valuesis required as a peer dependency in both the core and sovran packages. This is used for UUID v4 generation.I am using
react-native-quick-cryptoin my app and already polyfill thecrypto.getRandomValuesfunction globally. The peer dependency forces me to installreact-native-get-random-valueseven though it no-op on setup.On the same topic:
I have found in my testing that the UUID generation done on the native side is about 40% faster then using the JS
uuidpackage. Looking back a past PRs and issues, it seems that it has bounced around a few times from being a pure native function to then usinguuidand a polyfill because issues while debugging.I wonder if there is a middle ground where it checks for the best solution at run time, without needing to use a slower solution all the time.
Example:
crypto.randomUUID()-> if native module, generate uuid -> use polyfill anduuidpackage.