Adroll Enhanced-Conversion-Tracking seem to be broken

[POD666]

I'm trying to setup Adroll Pixel and looks like it doesn't load correctly.
Inspecting html of my page I see that following script was attached:
https://s.adroll.com/j/roundtrip.js
However, a "Global Tag" script shared with me by a vendor contains following:
var roundtripUrl = "https://s.adroll.com/j/" + adroll_adv_id + "/roundtrip.js";
So, I guess it's expected to be this in my case:
https://s.adroll.com/j/EKIOHU72NVCSXPIUSN7HMW/roundtrip.js

The implementation seem to refer to outdated docs, those docs link doesn't even work:
https://github.com/segmentio/analytics.js-integrations/blob/master/integrations/adroll/lib/index.js#L18-L48

Here I found another page describing this:
https://help.adroll.com/hc/en-us/articles/212629938-Enhanced-Conversion-Tracking#conversion-revenue-0-2

I also opened a support ticket if that matters: Id #569903

[mdkhan-tw]

Review of Issue #823: AdRoll Enhanced Conversion Tracking

Summary

Confirmed: The AdRoll integration is loading an incorrect script URL. The current implementation loads a generic script without the advertiser ID in the path, while AdRoll's Global Tag format requires the advertiser ID to be included.

The Problem

Current implementation (lines 29-30 in /integrations/adroll/lib/index.js):

.tag('http', '<script src="http://a.adroll.com/j/roundtrip.js">')
.tag('https', '<script src="https://s.adroll.com/j/roundtrip.js">')

Expected format (according to the vendor's Global Tag):

var roundtripUrl = "https://s.adroll.com/j/" + adroll_adv_id + "/roundtrip.js";
// Should result in: https://s.adroll.com/j/EKIOHU72NVCSXPIUSN7HMW/roundtrip.js

Root Cause Analysis

1. Hardcoded script URL: The integration uses a static script URL that doesn't include the advId in the path, even though the advId is available as this.options.advId and is already being set to window.adroll_adv_id (line 43).

2. Outdated documentation links: The code references AdRoll support URLs (lines 36-37) that are no longer valid, suggesting the implementation may be based on an older AdRoll API.

3. Script loading timing: The script is loaded generically without the advertiser-specific path, which may prevent proper pixel initialization or tracking functionality.

Impact

• The AdRoll pixel may not load correctly for users
• Conversion tracking and enhanced conversion features may not work
• Users cannot properly implement AdRoll tracking through Segment

Recommendation

The integration needs to be updated to:

1. Include the advertiser ID in the script path: Modify the tag definitions to dynamically construct the URL with advId:

   // Instead of static tags, construct the URL dynamically in initialize()
   var scriptUrl = 'https://s.adroll.com/j/' + this.options.advId + '/roundtrip.js';

2. Update or remove broken documentation links: The support links in the code comments should be updated to valid URLs or removed.

3. Verify with current AdRoll documentation: Check AdRoll's current implementation guide to ensure all aspects of the pixel are correctly implemented.

4. Add tests: The test suite should verify that the correct script URL format is being used, including the advertiser ID in the path.

This appears to be a legitimate bug that needs fixing to restore proper AdRoll functionality for Segment customers.

[mdkhan-tw]

#848