Merge pull request #240 from fredsa/errorclick

Improve compile error message click behavior

Author: sehugg

css/ui.css

@@ -159,6 +159,9 @@ div.is-busy-unused {
 #error_alert_msg {
   margin-right: 2em;
 }
+#error_alert_msg a {
+  cursor: pointer;
+}
 div.menu_div {
   position: absolute;
   width: 200px;

src/ide/ui.ts

@@ -870,7 +870,7 @@ function getErrorElement(err: WorkerError) {
       link.click((ev) => {
         var wnd = projectWindows.createOrShow(path);
         if (wnd instanceof SourceEditor) {
-          wnd.setCurrentLine(err, true);
+          wnd.navigateToLine(err.line);
         }
       });
     }

src/ide/views/editors.ts

@@ -341,6 +341,19 @@ export class SourceEditor implements ProjectView {
     });
   }
 
+  navigateToLine(line: number) {
+    if (line < 1 || line > this.editor.state.doc.lines) return;
+    const targetLine = this.editor.state.doc.line(line);
+    this.editor.dispatch({
+      selection: { anchor: targetLine.from },
+      effects: [
+        highlightLines.effect.of({ start: line, end: line }),
+        EditorView.scrollIntoView(targetLine.from, { y: "center" }),
+      ],
+    });
+    this.editor.focus();
+  }
+
   getValue(): string {
     return this.editor.state.doc.toString();
   }

src/ide/windows.ts

@@ -71,7 +71,7 @@ export class ProjectWindows {
       this.refreshErrors();
       wnd.setVisible && wnd.setVisible(true);
       this.id2showfn[id] && this.id2showfn[id](id, wnd);
-    } else {
+    } else if (moveCursor) {
       this.refresh(moveCursor);
     }
     this.activeid = id;