Implement Settings screen, fix shiftTab, enable tab indent#234
Merged
Conversation
Contributor
Author
|
(Partially) addresses #229 |
fredsa
force-pushed
the
indent
branch
2 times, most recently
from
7ac5306 to
5298811
Compare
fredsa
force-pushed
the
indent
branch
3 times, most recently
from
fd2b555 to
f14bd57
Compare
Contributor
Author
|
Here's what the settings screen looks like: 
|
- Tab size (default 8) - Insert spaces when pressing TAB - Highlight special characters - Highlight whitespace - Highlight unwanted trailing whitespace - Automatically add and remove closing brackets
shiftTab had incorrectly assumed all indentation was done with spaces
Owner
|
I got smart indent behavior working on the main branch based on a assembler/not-assembler test, seems to work for me or at least similar to CM5. I'm not sure how insert spaces = off (use tabs) interacts with smart indent, maybe smart indent is just disabled in this case since it always inserts spaces. (Or maybe it's fine since this is how CM5 worked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New settings menu
- Tab size (default 8)
- Insert spaces when pressing TAB
- Highlight special characters
- Highlight whitespace
- Highlight unwanted trailing whitespace
- Automatically add and remove closing brackets