paddle/joystick improvements, add Apple II support#243
Merged
Conversation
Fix mouse cacluations to account for non-integer canvas scale, and rect posistion & size, and replace Math.floor() with Math.round(). Fixes - Unreachable max x/y value in some cases. - Disproportionate number of mouse pixels for min and max mouse positions.
Ignore canvas borders and padding. This has the nice benefit that it's much easier to land on min/max mouse x/y, especially when moving the mouse quickly.
Values remain centered until mouse move events are received.
Owner
|
Fun! Like using a light pen :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canvas content coordinates, ignoring borders and padding
number of screen pixels for these values, and having borders
and padding capture mouse events for these values