-
Notifications
You must be signed in to change notification settings - Fork 51
Disable wallet tools by default #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@sei-js/mcp-server": patch | ||
| --- | ||
|
|
||
| Disable wallet based tools by default, add ability to add more wallet providers |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,15 @@ | ||
| # Sei MCP Server Environment Variables | ||
|
|
||
| # Wallet Configuration | ||
| # Wallet mode: private-key | dynamic | porto | disabled | ||
| # - disabled: Disable all wallet functionality (default - safest for production) | ||
| # - private-key: Use PRIVATE_KEY environment variable | ||
| WALLET_MODE=disabled | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we assume we are in readonly mode if no private key is set?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It does default to disabled if no private key. We could make it not required for the wallet mode, but with dynamic added we will still need a wallet mode for that. |
||
|
|
||
| # Private key for blockchain transactions (without 0x prefix) | ||
| # This is used when no private key is provided in the request | ||
| # Used when WALLET_MODE=private-key | ||
| # SECURITY: Never commit your actual private key to version control | ||
| PRIVATE_KEY=your_private_key_here | ||
|
|
||
| # Wallet API Key (future use with wallet providers) | ||
| # WALLET_API_KEY=your_wallet_api_key_here | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, how will this work for dynamic and porto modes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It extends that same WalletProvider interface and adds a new wallet mode "dynamic"