Skip to content

Commit 0f64e8f

Browse files
authored
Simplify layer parsing loop in Packet. (#2167)
1 parent 8570faa commit 0f64e8f

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

Packet++/src/Packet.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -739,9 +739,8 @@ namespace pcpp
739739
const uint8_t* dataPtr = m_RawPacket->getRawData();
740740

741741
// go over all layers from the first layer to the last layer and set the data ptr and data length for each layer
742-
Layer* curLayer = m_FirstLayer;
743742
bool passedExtendedLayer = false;
744-
while (curLayer != nullptr)
743+
for (Layer* curLayer = m_FirstLayer; curLayer != nullptr; curLayer = curLayer->getNextLayer())
745744
{
746745
if (dataPtr > m_RawPacket->getRawData() + m_RawPacket->getRawDataLen())
747746
{
@@ -766,7 +765,6 @@ namespace pcpp
766765
// assuming header length of the layer that requested to be extended hasn't been enlarged yet
767766
headerLen -= (curLayer == layer ? numOfBytesToShorten : 0);
768767
dataPtr += headerLen;
769-
curLayer = curLayer->getNextLayer();
770768
}
771769

772770
return true;

0 commit comments

Comments
 (0)