Fix IPcapStatisticsProvider::getStatistics() unresolved symbol error when building without libpcap. (#2146)

* Move `IPcapStatisticsProvider:;getStatistics` to be implemented inline.

Remove `PcapDevice.cpp` file due to no implementation.

* Add test case.

* typo

* Update clang tidy to exclude deleted files from checks in change tracking mode.

* Use --diff-filter exclude syntax instead of including every valid mode.

Author: Dimi1010

Pcap++/CMakeLists.txt

@@ -10,7 +10,6 @@ add_library(
   $<$<BOOL:${PCAPPP_USE_PCAP}>:src/PcapUtils.cpp>
   $<$<BOOL:${PCAPPP_USE_PCAP}>:src/NetworkUtils.cpp>
   src/PcapFileDevice.cpp
-  $<$<BOOL:${PCAPPP_USE_PCAP}>:src/PcapDevice.cpp>
   src/PcapFilter.cpp
   $<$<BOOL:${PCAPPP_USE_PCAP}>:src/PcapLiveDevice.cpp>
   $<$<BOOL:${PCAPPP_USE_PCAP}>:src/PcapLiveDeviceList.cpp>

Pcap++/header/PcapDevice.h

@@ -28,7 +28,12 @@ namespace pcpp
 
 		/// @brief Get statistics from the device
 		/// @return An object containing the stats
-		PcapStats getStatistics() const;
+		PcapStats getStatistics() const
+		{
+			PcapStats stats;
+			getStatistics(stats);
+			return stats;
+		}
 
 		/// Get statistics from the device
 		/// @param[out] stats An object containing the stats

Pcap++/src/PcapDevice.cpp

@@ -212,6 +212,11 @@ PTF_TEST_CASE(TestPcapFileReadWrite)
 			PTF_ASSERT_TRUE(writerDev.writePacket(rawPacket));
 		}
 
+		// TODO: Fix defect where getStatistics() is shadowed in derived classes.
+		auto rs = static_cast<pcpp::IPcapStatisticsProvider&>(readerDev).getStatistics();
+		PTF_ASSERT_EQUAL((uint32_t)rs.packetsRecv, 4631);
+		PTF_ASSERT_EQUAL((uint32_t)rs.packetsDrop, 0);
+
 		pcpp::PcapStats readerStatistics;
 		pcpp::PcapStats writerStatistics;
 

Tests/Pcap++Test/Tests/FileTests.cpp

@@ -18,7 +18,8 @@ BUILD_DIR=${2:-build}
 if [ "$MODE" = "changed" ]; then
     # Get the list of changed files from origin/dev
     git fetch origin dev
-    files=$(git diff --name-only origin/dev -- '*.cpp' '*.h' | grep -v '3rdParty/' || true)
+    # --diff-filter excludes deleted files (D) as they no longer exist.
+    files=$(git diff --name-only --diff-filter=d origin/dev -- '*.cpp' '*.h' | grep -v '3rdParty/' || true)
 else
     # Find all relevant files
     files=$(find "${ROOTPATH}" -type f \( -name '*.cpp' -o -name '*.h' \) -not -path "*/3rdParty/*")

ci/clang-tidy-all-new.sh

@@ -18,7 +18,8 @@ BUILD_DIR=${2:-build}
 if [ "$MODE" = "changed" ]; then
     # Get the list of changed files from origin/dev
     git fetch origin dev
-    files=$(git diff --name-only origin/dev -- '*.cpp' '*.h' | grep -v '3rdParty/' || true)
+    # --diff-filter excludes deleted files (D) as they no longer exist.
+    files=$(git diff --name-only --diff-filter=d origin/dev -- '*.cpp' '*.h' | grep -v '3rdParty/' || true)
 else
     # Find all relevant files
     files=$(find "${ROOTPATH}" -type f \( -name '*.cpp' -o -name '*.h' \) -not -path "*/3rdParty/*")