Skip to content

Fix use-of-uninitialized-value in PcapNgFileReaderDevice::getNextPacketInternal #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubham7-1 wants to merge 4 commits into
base: master
Choose a base branch
from
+3 −1
Open

Fix use-of-uninitialized-value in PcapNgFileReaderDevice::getNextPacketInternal #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
301e792
Fix use-of-uninitialized-value in PcapNgFileReaderDevice::getNextPack…
Copilot May 8, 2026
ee300a8
Add comment explaining 0xFFFF sentinel value for data_link
Copilot May 8, 2026
2226144
Merge pull request #1 from Shivam7-1/copilot/fix-use-of-uninitialized…
Shivam7-1 May 8, 2026
bba6198
Merge pull request #1 from Shivam7-1/master
Shubham7-1 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 3rdParty/LightPcapNg/LightPcapNg/src/light_pcapng_ext.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,8 @@ int light_get_next_packet(light_pcapng_t *pcapng, light_packet_header *packet_he
packet_header->timestamp.tv_nsec = 0;
if (pcapng->file_info->interface_block_count > 0)
packet_header->data_link = pcapng->file_info->link_types[0];
else
packet_header->data_link = 0xFFFF; /* unknown/invalid link type sentinel (no interface block present) */

*packet_data = (uint8_t*)spb->packet_data;
}
Expand Down
2 changes: 1 addition & 1 deletion Pcap++/src/PcapFileDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,7 +874,7 @@ namespace pcpp
return false;
}

light_packet_header pktHeader;
light_packet_header pktHeader{};
const uint8_t* pktData = nullptr;

if (!light_get_next_packet(toLightPcapNgT(m_LightPcapNg), &pktHeader, &pktData))
Expand Down