Update Arm and ICPX images to Ubuntu 26.04#2185
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2185 +/- ##
==========================================
- Coverage 82.78% 82.66% -0.13%
==========================================
Files 332 332
Lines 60059 60154 +95
Branches 12406 12528 +122
==========================================
+ Hits 49722 49724 +2
- Misses 8940 9020 +80
- Partials 1397 1410 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
seladb
commented
Jul 13, 2026
|
|
||
| # Fetch Google Benchmark | ||
| FetchContent_Declare(benchmark GIT_REPOSITORY https://github.com/google/benchmark.git GIT_TAG v1.9.0) | ||
| FetchContent_Declare(benchmark GIT_REPOSITORY https://github.com/google/benchmark.git GIT_TAG v1.9.5) |
Owner
Author
There was a problem hiding this comment.
This upgrade is needed to get this fix: google/benchmark#2108 that breaks CI with ICPX: https://github.com/seladb/PcapPlusPlus/actions/runs/29216259673/job/86712680266
seladb
commented
Jul 13, 2026
|
|
||
| add_executable(BenchmarkExampleGoogle benchmark-google.cpp) | ||
|
|
||
| target_compile_definitions(BenchmarkExampleGoogle PRIVATE NOMINMAX) |
Owner
Author
There was a problem hiding this comment.
This change is needed to fix this issue that break CI on VS 2026 (after upgrading Google Benchmark to v1.9.5): https://github.com/seladb/PcapPlusPlus/actions/runs/29217148400/job/86715127841
tigercosmos
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the images being used for ICPX and Arm to images based on Ubuntu 26.04