feat(action_status_bridge): add aborted-goal to faults bridge#423
Open
mfaferek93 wants to merge 2 commits into
Open
feat(action_status_bridge): add aborted-goal to faults bridge#423mfaferek93 wants to merge 2 commits into
mfaferek93 wants to merge 2 commits into
Conversation
New ros2_medkit_action_status_bridge: watches */_action/status and turns terminal ABORTED goal states into FaultManager faults, healing on SUCCEEDED. Catches action-result failures that never reach /rosout or /diagnostics (MoveIt, Nav2, ros2_control). Refs #421
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ROS 2 package, ros2_medkit_action_status_bridge, that discovers action */_action/status topics at runtime and converts terminal goal states into FaultManager faults (with optional healing on SUCCEEDED). This complements existing log/diagnostic-based fault sources by capturing failures that only appear on the action status channel.
Changes:
- Introduces
ActionStatusBridgeNodethat periodically rescans the graph, subscribes to action status topics, deduplicates terminal events per goal, and reports/heals faults viaros2_medkit_fault_reporter. - Adds launch + YAML configuration, plus package/build metadata for installation.
- Adds GTest unit tests for topic parsing, fault-code formatting, UUID hex conversion, and node construction.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ros2_medkit_action_status_bridge/test/test_action_status_bridge.cpp | New unit tests for helper logic and node creation |
| src/ros2_medkit_action_status_bridge/src/main.cpp | Node entrypoint (init/spin/shutdown) |
| src/ros2_medkit_action_status_bridge/src/action_status_bridge_node.cpp | Core bridge implementation: discovery, subscriptions, dedup, fault reporting |
| src/ros2_medkit_action_status_bridge/README.md | Package overview and configuration docs |
| src/ros2_medkit_action_status_bridge/package.xml | New ROS package manifest and dependencies |
| src/ros2_medkit_action_status_bridge/launch/action_status_bridge.launch.py | Launch file to run the bridge with YAML params |
| src/ros2_medkit_action_status_bridge/include/ros2_medkit_action_status_bridge/action_status_bridge_node.hpp | Public node API + documentation |
| src/ros2_medkit_action_status_bridge/config/action_status_bridge.yaml | Default parameters for the bridge |
| src/ros2_medkit_action_status_bridge/CMakeLists.txt | Build, install, and unit-test wiring |
| src/ros2_medkit_action_status_bridge/CHANGELOG.rst | Initial changelog entry |
Per-action lifecycle state derived from the whole status array (raise/heal on real transitions, no per-goal masking), sanitized code_prefix, pruning of vanished actions, CANCELED-aware codes, param validation, QoS-incompat warning. Unique test domain range, dropped unused test_depends, added unit coverage; docs corrected.
mfaferek93
force-pushed
the
feat/421-action-status-bridge
branch
from
6614b45 to
53d1a91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ros2_medkit_action_status_bridge, a generic drop-in adapter that discovers every action via its*/_action/statustopic and turns terminalABORTEDgoal states into FaultManager faults, healing the code onSUCCEEDED.This captures the authoritative failure channel for the core stacks (Nav2, MoveIt 2, ros2_control), where an aborted goal reaches neither
/rosoutnor/diagnostics.source_idis the action name;fault_codeis<PREFIX>_<ACTION>_ABORTED.goal_idso a latched terminal status reports once.Unit tests cover action-name extraction, fault_code generation, and dedup.
Closes #421