Skip to content

Commit 08d4b54

Browse files
committed
fix(moveit-demo): restore rosdep || true with explanatory comment
ros2_medkit packages are not in rosdep indices (built from source), so rosdep install always exits non-zero. The || true is necessary but now has a comment explaining why.
1 parent ce2d55c commit 08d4b54

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

demos/moveit_pick_place/Dockerfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,13 @@ COPY launch/ ${COLCON_WS}/src/moveit_medkit_demo/launch/
5151
COPY scripts/ ${COLCON_WS}/src/moveit_medkit_demo/scripts/
5252

5353
# Build ros2_medkit and demo package
54+
# Note: rosdep install uses || true because ros2_medkit packages are not in
55+
# rosdep indices (they're built from source). All system deps are already
56+
# installed via apt above; rosdep handles any transitive deps it can resolve.
5457
WORKDIR ${COLCON_WS}
5558
RUN bash -c "source /opt/ros/jazzy/setup.bash && \
5659
rosdep update && \
57-
rosdep install --from-paths src --ignore-src -r -y" && \
60+
rosdep install --from-paths src --ignore-src -r -y || true" && \
5861
bash -c "source /opt/ros/jazzy/setup.bash && \
5962
colcon build --symlink-install --cmake-args -DBUILD_TESTING=OFF"
6063

0 commit comments

Comments
 (0)