test: extend smoke tests for v0.4.0 features and missing API coverage

bburda · bburda · commit 0ed6f4997a88 · 2026-03-24T12:49:35.000+01:00
Add smoke test assertions for new gateway v0.4.0 features across all 3 demos (sensor, moveit, turtlebot3): - Linux introspection (procfs plugin data per entity) - Scripts API (list scripts, execute, poll completion) - Triggers CRUD (create, list, verify, delete) for moveit/turtlebot - Beacon discovery (sensor demo, conditional on BEACON_MODE) Fill gaps in pre-v0.4.0 API coverage: - Functions entity discovery (all demos) - Discovery relationships (areas -> components) - Operations endpoint (via medkit-fault-manager) - Data access and configurations (moveit, turtlebot) - Bulk data endpoint (all demos) - Faults listing (moveit, turtlebot) Add reusable helpers to smoke_lib.sh: - assert_procfs_introspection - assert_scripts_list / assert_script_execution - assert_triggers_crud Tested against sensor_diagnostics demo: 40/40 pass. Closes #45
diff --git a/tests/smoke_lib.sh b/tests/smoke_lib.sh
@@ -162,6 +162,178 @@ test_entity_discovery() {
     fi
 }
 
+# Test that procfs introspection data is available for an app
+# Usage: assert_procfs_introspection "lidar-sim"
+assert_procfs_introspection() {
+    local app_id="$1"
+    local endpoint="/apps/${app_id}/x-medkit-procfs"
+    if api_get "$endpoint"; then
+        if echo "$RESPONSE" | jq -e '.pid' > /dev/null 2>&1; then
+            pass "GET ${endpoint} returns procfs data with pid"
+        else
+            fail "GET ${endpoint} returns procfs data with pid" "pid field missing"
+        fi
+    else
+        fail "GET ${endpoint} returns 200" "unexpected status code"
+    fi
+}
+
+# Test that scripts are listed for a component
+# Usage: assert_scripts_list "compute-unit" "run-diagnostics"
+assert_scripts_list() {
+    local component_id="$1"
+    local expected_script="$2"
+    local endpoint="/components/${component_id}/scripts"
+    if api_get "$endpoint"; then
+        if echo "$RESPONSE" | jq -e '.items | length > 0' > /dev/null 2>&1; then
+            pass "GET ${endpoint} returns non-empty items"
+        else
+            fail "GET ${endpoint} returns non-empty items" "items is empty"
+        fi
+        if echo "$RESPONSE" | jq -e --arg s "$expected_script" '.items[] | select(.id == $s)' > /dev/null 2>&1; then
+            pass "scripts contains '${expected_script}'"
+        else
+            fail "scripts contains '${expected_script}'" "not found in response"
+        fi
+    else
+        fail "GET ${endpoint} returns 200" "unexpected status code"
+    fi
+}
+
+# Execute a script and verify it completes
+# Usage: assert_script_execution "compute-unit" "run-diagnostics" [max_wait]
+assert_script_execution() {
+    local component_id="$1"
+    local script_id="$2"
+    local max_wait="${3:-30}"
+    local exec_endpoint="/components/${component_id}/scripts/${script_id}/executions"
+
+    # Start execution
+    local exec_response
+    exec_response=$(curl -s -w "\n%{http_code}" -X POST "${API_BASE}${exec_endpoint}" \
+        -H "Content-Type: application/json" \
+        -d '{"execution_type": "now"}' 2>/dev/null) || true
+    local exec_http
+    exec_http=$(echo "$exec_response" | tail -1)
+    local exec_body
+    exec_body=$(echo "$exec_response" | sed '$d')
+
+    if [ "$exec_http" != "201" ] && [ "$exec_http" != "200" ] && [ "$exec_http" != "202" ]; then
+        fail "POST ${exec_endpoint} starts execution" "got HTTP ${exec_http}"
+        return
+    fi
+    pass "POST ${exec_endpoint} starts execution"
+
+    local exec_id
+    exec_id=$(echo "$exec_body" | jq -r '.id')
+    if [ -z "$exec_id" ] || [ "$exec_id" = "null" ]; then
+        fail "script execution returns valid id" "id is null or empty"
+        return
+    fi
+    pass "script execution returns valid id"
+
+    # Poll until completed
+    echo "  Waiting for script '${script_id}' to complete (max ${max_wait}s)..."
+    local elapsed=0
+    while [ $elapsed -lt "$max_wait" ]; do
+        if api_get "${exec_endpoint}/${exec_id}"; then
+            local status
+            status=$(echo "$RESPONSE" | jq -r '.status')
+            case "$status" in
+                completed)
+                    pass "script '${script_id}' completed successfully"
+                    return
+                    ;;
+                failed|terminated)
+                    fail "script '${script_id}' completed successfully" "status: ${status}"
+                    return
+                    ;;
+            esac
+        fi
+        sleep 1
+        elapsed=$((elapsed + 1))
+    done
+    fail "script '${script_id}' completed successfully" "timed out after ${max_wait}s"
+}
+
+# Test trigger CRUD lifecycle on an entity
+# Usage: assert_triggers_crud "apps" "diagnostic-bridge" "/api/v1/apps/diagnostic-bridge/faults"
+assert_triggers_crud() {
+    local entity_type="$1"
+    local entity_id="$2"
+    local resource_uri="$3"
+    local triggers_endpoint="/${entity_type}/${entity_id}/triggers"
+
+    # Create trigger
+    echo "  Creating OnChange trigger on ${entity_type}/${entity_id}..."
+    local create_response
+    create_response=$(curl -s -w "\n%{http_code}" -X POST "${API_BASE}${triggers_endpoint}" \
+        -H "Content-Type: application/json" \
+        -d "{\"resource\":\"${resource_uri}\",\"trigger_condition\":{\"condition_type\":\"OnChange\"},\"multishot\":true,\"lifetime\":60}" 2>/dev/null) || true
+
+    local create_http
+    create_http=$(echo "$create_response" | tail -1)
+    local create_body
+    create_body=$(echo "$create_response" | sed '$d')
+
+    if [ "$create_http" = "201" ]; then
+        pass "POST ${triggers_endpoint} returns 201"
+    else
+        fail "POST ${triggers_endpoint} returns 201" "got HTTP ${create_http}"
+        return
+    fi
+
+    local trigger_id
+    trigger_id=$(echo "$create_body" | jq -r '.id')
+    if [ -n "$trigger_id" ] && [ "$trigger_id" != "null" ]; then
+        pass "trigger response contains valid id"
+    else
+        fail "trigger response contains valid id" "id is null or empty"
+        return
+    fi
+
+    local trigger_status
+    trigger_status=$(echo "$create_body" | jq -r '.status')
+    if [ "$trigger_status" = "active" ]; then
+        pass "trigger status is 'active'"
+    else
+        fail "trigger status is 'active'" "got '${trigger_status}'"
+    fi
+
+    # List triggers - verify it appears
+    if api_get "${triggers_endpoint}"; then
+        if echo "$RESPONSE" | jq -e --arg id "$trigger_id" '.items[] | select(.id == $id)' > /dev/null 2>&1; then
+            pass "GET ${triggers_endpoint} lists created trigger"
+        else
+            fail "GET ${triggers_endpoint} lists created trigger" "trigger ${trigger_id} not found"
+        fi
+    else
+        fail "GET ${triggers_endpoint} returns 200" "unexpected status code"
+    fi
+
+    # Delete trigger
+    local delete_status
+    delete_status=$(curl -s -o /dev/null -w "%{http_code}" -X DELETE \
+        "${API_BASE}${triggers_endpoint}/${trigger_id}" 2>/dev/null) || true
+
+    if [ "$delete_status" = "204" ]; then
+        pass "DELETE trigger ${trigger_id} returns 204"
+    else
+        fail "DELETE trigger ${trigger_id} returns 204" "got HTTP ${delete_status}"
+    fi
+
+    # Verify trigger is gone
+    if api_get "${triggers_endpoint}"; then
+        if ! echo "$RESPONSE" | jq -e --arg id "$trigger_id" '.items[] | select(.id == $id)' > /dev/null 2>&1; then
+            pass "trigger no longer listed after deletion"
+        else
+            fail "trigger no longer listed after deletion" "still found in list"
+        fi
+    else
+        fail "GET ${triggers_endpoint} returns 200 after delete" "unexpected status code"
+    fi
+}
+
 # Print test summary and exit with appropriate code
 print_summary() {
     echo ""
diff --git a/tests/smoke_test.sh b/tests/smoke_test.sh
@@ -34,6 +34,15 @@ fi
 test_entity_discovery "areas" sensors processing diagnostics
 test_entity_discovery "components" lidar-unit imu-unit gps-unit camera-unit
 test_entity_discovery "apps" lidar-sim imu-sim gps-sim camera-sim anomaly-detector
+test_entity_discovery "functions" sensor-monitoring anomaly-detection fault-management
+
+section "Discovery Relationships"
+
+assert_non_empty_items "/areas/sensors/components"
+
+section "Linux Introspection"
+
+assert_procfs_introspection "lidar-sim"
 
 section "Data Access"
 
@@ -49,6 +58,24 @@ else
     fail "configurations contains 'noise_stddev' parameter" "not found in response"
 fi
 
+section "Operations"
+
+assert_non_empty_items "/apps/medkit-fault-manager/operations"
+
+section "Scripts"
+
+assert_scripts_list "compute-unit" "run-diagnostics"
+assert_script_execution "compute-unit" "run-diagnostics" 30
+
+section "Bulk Data"
+
+# Bulk data endpoint should return 200 with categories list (may be empty without faults)
+if api_get "/apps/diagnostic-bridge/bulk-data"; then
+    pass "GET /apps/diagnostic-bridge/bulk-data returns 200"
+else
+    fail "GET /apps/diagnostic-bridge/bulk-data returns 200" "unexpected status code"
+fi
+
 section "Logs"
 
 assert_non_empty_items "/apps/medkit-gateway/logs"
@@ -177,6 +204,35 @@ else
     fail "GET /apps/diagnostic-bridge/triggers returns 200 after delete" "unexpected status code"
 fi
 
+section "Beacon Discovery"
+
+# Beacon data is exposed at vendor extension endpoints:
+#   /apps/{id}/x-medkit-topic-beacon  (BEACON_MODE=topic)
+#   /apps/{id}/x-medkit-param-beacon  (BEACON_MODE=param)
+# When BEACON_MODE=none (CI default), these endpoints return 404.
+beacon_found=false
+for beacon_type in topic-beacon param-beacon; do
+    if api_get "/apps/lidar-sim/x-medkit-${beacon_type}"; then
+        beacon_found=true
+        pass "GET /apps/lidar-sim/x-medkit-${beacon_type} returns 200"
+        if echo "$RESPONSE" | jq -e '.status' > /dev/null 2>&1; then
+            pass "beacon response contains 'status' field"
+        else
+            fail "beacon response contains 'status' field" "field missing"
+        fi
+        if echo "$RESPONSE" | jq -e '.entity_id' > /dev/null 2>&1; then
+            pass "beacon response contains 'entity_id' field"
+        else
+            fail "beacon response contains 'entity_id' field" "field missing"
+        fi
+        break
+    fi
+done
+if [ "$beacon_found" = false ]; then
+    # Not a failure - beacons are optional depending on BEACON_MODE
+    echo -e "  ${BLUE}SKIP${NC} beacon not active (BEACON_MODE=none or plugin not loaded)"
+fi
+
 # --- Summary ---
 
 print_summary
diff --git a/tests/smoke_test_moveit.sh b/tests/smoke_test_moveit.sh
@@ -35,11 +35,57 @@ fi
 test_entity_discovery "areas" manipulation planning diagnostics bridge
 test_entity_discovery "components" panda-arm panda-gripper moveit-planning pick-place-loop gateway fault-manager diagnostic-bridge
 test_entity_discovery "apps" joint-state-broadcaster panda-arm-controller panda-hand-controller robot-state-publisher move-group pick-place-node medkit-gateway medkit-fault-manager diagnostic-bridge-app manipulation-monitor
+test_entity_discovery "functions" pick-and-place motion-planning gripper-control fault-management
+
+section "Discovery Relationships"
+
+assert_non_empty_items "/areas/manipulation/components"
+
+section "Linux Introspection"
+
+assert_procfs_introspection "medkit-gateway"
+
+section "Data Access"
+
+assert_non_empty_items "/apps/medkit-gateway/data"
+
+section "Operations"
+
+assert_non_empty_items "/apps/medkit-fault-manager/operations"
+
+section "Configurations"
+
+assert_non_empty_items "/apps/medkit-gateway/configurations"
+
+section "Scripts"
+
+assert_scripts_list "moveit-planning" "arm-self-test"
+assert_script_execution "moveit-planning" "arm-self-test" 30
+
+section "Bulk Data"
+
+if api_get "/apps/diagnostic-bridge-app/bulk-data"; then
+    pass "GET /apps/diagnostic-bridge-app/bulk-data returns 200"
+else
+    fail "GET /apps/diagnostic-bridge-app/bulk-data returns 200" "unexpected status code"
+fi
+
+section "Faults"
+
+if api_get "/faults"; then
+    pass "GET /faults returns 200"
+else
+    fail "GET /faults returns 200" "unexpected status code"
+fi
 
 section "Logs"
 
 assert_non_empty_items "/apps/medkit-gateway/logs"
 
+section "Triggers"
+
+assert_triggers_crud "apps" "diagnostic-bridge-app" "/api/v1/apps/diagnostic-bridge-app/faults"
+
 # --- Summary ---
 
 print_summary
diff --git a/tests/smoke_test_turtlebot3.sh b/tests/smoke_test_turtlebot3.sh
@@ -36,11 +36,57 @@ fi
 test_entity_discovery "areas" robot navigation diagnostics bridge
 test_entity_discovery "components" turtlebot3-base lidar-sensor nav2-stack gateway fault-manager diagnostic-bridge-unit
 test_entity_discovery "apps" turtlebot3-node robot-state-publisher amcl bt-navigator controller-server planner-server velocity-smoother medkit-gateway medkit-fault-manager diagnostic-bridge anomaly-detector
+test_entity_discovery "functions" autonomous-navigation robot-control fault-management
+
+section "Discovery Relationships"
+
+assert_non_empty_items "/areas/robot/components"
+
+section "Linux Introspection"
+
+assert_procfs_introspection "medkit-gateway"
+
+section "Data Access"
+
+assert_non_empty_items "/apps/medkit-gateway/data"
+
+section "Operations"
+
+assert_non_empty_items "/apps/medkit-fault-manager/operations"
+
+section "Configurations"
+
+assert_non_empty_items "/apps/medkit-gateway/configurations"
+
+section "Scripts"
+
+assert_scripts_list "nav2-stack" "nav-health-check"
+assert_script_execution "nav2-stack" "nav-health-check" 30
+
+section "Bulk Data"
+
+if api_get "/apps/diagnostic-bridge/bulk-data"; then
+    pass "GET /apps/diagnostic-bridge/bulk-data returns 200"
+else
+    fail "GET /apps/diagnostic-bridge/bulk-data returns 200" "unexpected status code"
+fi
+
+section "Faults"
+
+if api_get "/faults"; then
+    pass "GET /faults returns 200"
+else
+    fail "GET /faults returns 200" "unexpected status code"
+fi
 
 section "Logs"
 
 assert_non_empty_items "/apps/medkit-gateway/logs"
 
+section "Triggers"
+
+assert_triggers_crud "apps" "diagnostic-bridge" "/api/v1/apps/diagnostic-bridge/faults"
+
 # --- Summary ---
 
 print_summary
