address PR review feedback on bottom_padding

paul-talma · paul-talma · commit 33053c0f205a · 2026-04-03T12:07:19.000-07:00
- use util.read_text/write_text instead of io.open (codebase convention)
- clamp bottom_padding to [0, 1] in setup()
- inject bottom_padding via data-bottom-padding HTML attribute instead of
  inline JS, avoiding syntax errors if token is unsubstituted in stale cache
diff --git a/assets/index.html b/assets/index.html
@@ -1,5 +1,5 @@
 <!doctype html>
-<html lang="en" data-theme="dark">
+<html lang="en" data-theme="dark" data-bottom-padding="__BOTTOM_PADDING__">
 
 <head>
     <meta charset="utf-8" />
@@ -839,7 +839,7 @@ <h1>Markdown Preview</h1>
         import mermaid from 'https://cdn.jsdelivr.net/npm/mermaid@11/dist/mermaid.esm.min.mjs';
         import markdownItGithubAlerts from 'https://unpkg.com/markdown-it-github-alerts@1.0.1/dist/index.mjs';
 
-        const BOTTOM_PADDING = __BOTTOM_PADDING__;
+        const BOTTOM_PADDING = parseFloat(document.documentElement.dataset.bottomPadding) || 0.5;
 
         // ── DOM refs ──────────────────────────────────────────────────
         const $ = (id) => document.getElementById(id);
diff --git a/lua/markdown_preview/init.lua b/lua/markdown_preview/init.lua
@@ -39,6 +39,7 @@ M.config = {
 
 function M.setup(opts)
 	M.config = vim.tbl_deep_extend("force", M.config, opts or {})
+	M.config.bottom_padding = math.max(0, math.min(1, M.config.bottom_padding))
 	M._mmdr_available = nil -- reset so next check re-probes
 end
 
@@ -51,16 +52,12 @@ M._debounce_seq = 0
 M._workspace_dir = nil
 M._mmdr_available = nil -- nil = unchecked, true/false after probe
 M._last_scroll_line = nil
-M._is_primary = nil -- true/false/nil (takeover mode)
-M._takeover_port = nil -- port of primary server (secondary uses for HTTP events)
+M._is_primary = nil      -- true/false/nil (takeover mode)
+M._takeover_port = nil   -- port of primary server (secondary uses for HTTP events)
 
 local function effective_port()
-	if M.config.port ~= 0 then
-		return M.config.port
-	end
-	if M.config.instance_mode == "takeover" then
-		return 8421
-	end
+	if M.config.port ~= 0 then return M.config.port end
+	if M.config.instance_mode == "takeover" then return 8421 end
 	return 0
 end
 
@@ -91,19 +88,9 @@ local function write_index(dir)
 	if not src then
 		error("Could not locate assets/index.html in runtimepath. Make sure the plugin ships it.")
 	end
-	local f = io.open(src, "r")
-	if not f then
-		error("Could not open " .. src)
-	end
-	local content = f:read("*a")
-	f:close()
+	local content = util.read_text(src)
 	content = content:gsub("__BOTTOM_PADDING__", tostring(M.config.bottom_padding))
-	local out = io.open(dst, "w")
-	if not out then
-		error("Could not write " .. dst)
-	end
-	out:write(content)
-	out:close()
+	util.write_text(dst, content)
 	return dst
 end
 
@@ -273,7 +260,8 @@ local function get_content(bufnr)
 	if ft == "markdown" then
 		local lines = vim.api.nvim_buf_get_lines(bufnr, 0, -1, false)
 		text = table.concat(lines, "\n")
-	elseif vim.api.nvim_buf_get_name(bufnr):match("%.mmd$") or vim.api.nvim_buf_get_name(bufnr):match("%.mermaid$") then
+	elseif vim.api.nvim_buf_get_name(bufnr):match("%.mmd$")
+        or vim.api.nvim_buf_get_name(bufnr):match("%.mermaid$") then
 		-- .mmd / .mermaid files: treat entire buffer as mermaid
 		local lines = vim.api.nvim_buf_get_lines(bufnr, 0, -1, false)
 		text = "```mermaid\n" .. table.concat(lines, "\n") .. "\n```\n"
@@ -357,13 +345,9 @@ end
 
 --- Send cursor line to browser for scroll sync.
 local function send_scroll_sync(bufnr)
-	if not M.config.scroll_sync then
-		return
-	end
+	if not M.config.scroll_sync then return end
 	local cursor_line = vim.api.nvim_win_get_cursor(0)[1] -- 1-based
-	if cursor_line == M._last_scroll_line then
-		return
-	end
+	if cursor_line == M._last_scroll_line then return end
 	M._last_scroll_line = cursor_line
 	local total = vim.api.nvim_buf_line_count(bufnr)
 	local payload = vim.json.encode({ line = cursor_line - 1, total = total })
@@ -401,9 +385,7 @@ local function set_autocmds_for_buffer(bufnr)
 		vim.api.nvim_create_autocmd(ev, {
 			group = M._augroup,
 			buffer = bufnr,
-			callback = function()
-				send_scroll_sync(bufnr)
-			end,
+			callback = function() send_scroll_sync(bufnr) end,
 			desc = "Markdown Preview scroll sync",
 		})
 	end
