Added commands and variables to run something when client connect/disconnect#169
Open
skipperro wants to merge 2 commits into
Open
Added commands and variables to run something when client connect/disconnect#169skipperro wants to merge 2 commits into
skipperro wants to merge 2 commits into
Conversation
- Added support for SELKIES_START_AFTER_CONNECT and SELKIES_START_AFTER_CONNECT variables - Added support for --start-after-connect and --start-after-disconnect start arguments - Removed duplicated base64 import in signalling_web.py
Member
|
I will review this but will take weeks before I gain enough dedicated time. Thank you! |
ehfd
requested changes
Dec 22, 2024
Member
ehfd
left a comment
There was a problem hiding this comment.
The overall code style by Dan Isla prefers using a Python-native variable over os.environ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional context