feat: expose apis for org management#1029
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4207363bfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import PipelinesAPI.Members.Authorize, only: [authorize_manage_people: 2] | ||
|
|
||
| plug(:authorize_manage_people) |
There was a problem hiding this comment.
Project-scoped role assignment is currently guarded by authorize_manage_people (organization.people.manage), but the RBAC gRPC server authorizes project role changes with project.access.manage when project_id is present (checked ee/rbac/lib/rbac/grpc_servers/rbac_server.ex, @manage_project_roles). This means users who are allowed to manage project access but not org people will be incorrectly blocked at the HTTP layer, while users with org-people manage but no project-access manage will hit backend denial and get a generic failure path.
Useful? React with 👍 / 👎.
| def authorize_manage_groups(conn, _opts) do | ||
| is_authorized?("organization.groups.manage", conn) |
There was a problem hiding this comment.
The API layer requires organization.groups.manage, but the groups gRPC server authorizes mutating calls with organization.people.manage (checked ee/rbac/lib/rbac/grpc_servers/groups_server.ex, @manage_groups_permission). That mismatch creates inconsistent behavior: a caller with only groups-manage can pass this plug and then fail downstream, while a caller with only people-manage is blocked here even though backend would permit the operation.
Useful? React with 👍 / 👎.
loadez
force-pushed
the
feat/org-management-api
branch
from
4207363 to
6c94994
Compare
loadez
force-pushed
the
feat/org-management-api
branch
4 times, most recently
from
57a0bc4 to
11922e9
Compare
Credo flagged mass 55 (threshold 45). Reuse serialize_members in process_list_members_response, delegate process_modify_role.
loadez
force-pushed
the
feat/org-management-api
branch
from
11922e9 to
265b092
Compare
is_authorized? duplicated across 4 authorize modules (mass 44x3). Extract to SharedAuthorize.check_permission/2, delegates only.
1 participant
📝 Description
✅ Checklist