build: remove dll from gap root#1159
Merged
james-d-mitchell merged 2 commits intoMar 28, 2026
Merged
Conversation
james-d-mitchell
approved these changes
Mar 27, 2026
Collaborator
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Looks good to me.
james-d-mitchell
pushed a commit
to james-d-mitchell/Semigroups
that referenced
this pull request
Mar 31, 2026
james-d-mitchell
pushed a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds to the
cleanrecipe so that thecygsemigroupsDLL gets removed from the gap-root (if it exists).I wasn't sure which recipe to include this in, so I followed this suggestion from the automake doc:
I'm happy to move it somewhere else if we're following a different paradigm.