Skip to content

Commit 35d6ffe

Browse files
committed
update prostocol mask
1 parent 7737138 commit 35d6ffe

4 files changed

Lines changed: 15 additions & 16 deletions

File tree

src/pygpsclient/app.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@
7070
from pygpsclient.configuration import Configuration
7171
from pygpsclient.dialog_state import DialogState
7272
from pygpsclient.file_handler import FileHandler
73-
from pygpsclient.globals import (
74-
UNI_PROTOCOL, # replace by pygnssutils value when available
75-
)
7673
from pygpsclient.globals import (
7774
BGCOL,
7875
CLASS,
@@ -100,6 +97,7 @@
10097
STATUSPRIORITY,
10198
TTY_PROTOCOL,
10299
UNDO,
100+
UNI_PROTOCOL,
103101
)
104102
from pygpsclient.gnss_status import GNSSStatus
105103
from pygpsclient.helpers import (
@@ -1241,9 +1239,10 @@ def protocol_mask(self) -> int:
12411239
+ (cfg.get("rtcmprot_b") * RTCM3_PROTOCOL) # 4
12421240
+ (cfg.get("sbfprot_b") * SBF_PROTOCOL) # 8
12431241
+ (cfg.get("qgcprot_b") * QGC_PROTOCOL) # 16
1244-
+ (cfg.get("spartnprot_b") * SPARTN_PROTOCOL) # 32
1245-
+ (cfg.get("mqttprot_b") * MQTT_PROTOCOL) # 64
1246-
+ (cfg.get("ttyprot_b") * TTY_PROTOCOL) # 128
1242+
+ (cfg.get("uniprot_b") * UNI_PROTOCOL) # 32
1243+
+ (cfg.get("spartnprot_b") * SPARTN_PROTOCOL) # 256
1244+
+ (cfg.get("mqttprot_b") * MQTT_PROTOCOL) # 512
1245+
+ (cfg.get("ttyprot_b") * TTY_PROTOCOL) # 1024
12471246
)
12481247
return mask
12491248

src/pygpsclient/configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def __init__(self, app):
116116
"rtcmprot_b": 1,
117117
"sbfprot_b": 0,
118118
"qgcprot_b": 0,
119-
"unicoreprot_b": 0,
119+
"uniprot_b": 0,
120120
"spartnprot_b": 0,
121121
"mqttprot_b": 1,
122122
"ttyprot_b": 0,

src/pygpsclient/globals.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@
5252
PLOTCOLS = ("#FFFF00", "#00FFFF", "#FF00FF", "#00BFFF")
5353
PNTCOL = "#FF8000" # default plot point color
5454

55-
# Protocols to be used in protocol mask (others defined in gnss_reader.py)
56-
SPARTN_PROTOCOL = 32
57-
MQTT_PROTOCOL = 64
58-
TTY_PROTOCOL = 128
59-
UNI_PROTOCOL = 256
55+
# Protocols to be used in protocol mask (others defined in pygnssutils.gnss_reader.py)
56+
UNI_PROTOCOL = 32 # provisional - awaiting pygnssutils.gnssreader updates for Unicore
57+
SPARTN_PROTOCOL = 256
58+
MQTT_PROTOCOL = 512
59+
TTY_PROTOCOL = 1024
6060

6161
# Various global constants - please keep in ascending alphabetical order
6262
HOME = Path.home()

src/pygpsclient/settings_child_frame.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ def _attach_events(self, add: bool = True):
508508
self._prot_ubx.trace_update(tracemode, self._on_update_ubxprot, add)
509509
self._prot_sbf.trace_update(tracemode, self._on_update_sbfprot, add)
510510
self._prot_qgc.trace_update(tracemode, self._on_update_qgcprot, add)
511-
self._prot_unicore.trace_update(tracemode, self._on_update_unicoreprot, add)
511+
self._prot_unicore.trace_update(tracemode, self._on_update_uniprot, add)
512512
self._prot_nmea.trace_update(tracemode, self._on_update_nmeaprot, add)
513513
self._prot_rtcm.trace_update(tracemode, self._on_update_rtcmprot, add)
514514
self._prot_spartn.trace_update(tracemode, self._on_update_spartnprot, add)
@@ -586,13 +586,13 @@ def _on_update_qgcprot(self, var, index, mode):
586586
if not self._prot_tty.get():
587587
self.__app.configuration.set("qgcprot_b", self._prot_qgc.get())
588588

589-
def _on_update_unicoreprot(self, var, index, mode):
589+
def _on_update_uniprot(self, var, index, mode):
590590
"""
591591
Action on updating unicoreprot.
592592
"""
593593

594594
if not self._prot_tty.get():
595-
self.__app.configuration.set("unicoreprot_b", self._prot_unicore.get())
595+
self.__app.configuration.set("uniprot_b", self._prot_unicore.get())
596596

597597
def _on_update_nmeaprot(self, var, index, mode):
598598
"""
@@ -644,7 +644,7 @@ def _on_update_ttyprot(self, var, index, mode):
644644
self._prot_ubx.set(cfg.get("ubxprot_b"))
645645
self._prot_sbf.set(cfg.get("sbfprot_b"))
646646
self._prot_qgc.set(cfg.get("qgcprot_b"))
647-
self._prot_unicore.set(cfg.get("unicoreprot_b"))
647+
self._prot_unicore.set(cfg.get("uniprot_b"))
648648
self._prot_rtcm.set(cfg.get("rtcmprot_b"))
649649
self._prot_spartn.set(cfg.get("spartnprot_b"))
650650
cfg.set("ttyprot_b", tty)

0 commit comments

Comments
 (0)