Fix Lab Information setup data import after Laboratory migration to Dexterity (#2918)

The Laboratory content type was migrated to Dexterity in #2810, where it
became folderish and inherited edit(title, description) from CMFCore's
PortalFolder. The Lab_Information setup data importer still called
laboratory.edit() with the old Archetypes field names (Name, LabURL,
Confidence, ...), which raised:

    TypeError: edit() got an unexpected keyword argument 'Name'

Update the importer to use api.edit() with the Dexterity schema field
names, matching the pattern already used for the migrated SampleType and
AnalysisProfile importers. Convert Confidence to int (now schema.Int),
wrap the accreditation logo in a NamedBlobImage (now a NamedBlobImage
field), and drop the obsolete AccreditationBodyLong value, which never
mapped to a field on the Archetypes type either.

Author: ramonski

CHANGES.rst

@@ -4,6 +4,7 @@ Changelog
 2.7.0 (unreleased)
 ------------------
 
+- #2918 Fix Lab Information setup data import after Laboratory migration to Dexterity
 - #2917 Fix `ClientID` is not displayed in samples listing, but client name
 - #2916 Fix msgid collision on `description_calculation_imports` in Calculation content type
 - #2915 Rename 'Duplicate' sample transition to 'Duplicate Sample' to avoid translation collision with the worksheet duplicate-analysis label

src/senaite/core/exportimport/setupdata/__init__.py

@@ -34,6 +34,7 @@
 from bika.lims.utils import to_utf8
 from bika.lims.utils.analysis import create_analysis
 from pkg_resources import resource_filename
+from plone.namedfile.file import NamedBlobImage
 from Products.Archetypes.event import ObjectInitializedEvent
 from Products.CMFCore.utils import getToolByName
 from Products.CMFPlone.utils import _createObjectByType
@@ -357,37 +358,44 @@ def Import(self):
 
 class Lab_Information(WorksheetImporter):
 
+    def get_logo(self, filename):
+        """Read a setup data image and return it as a NamedBlobImage
+        """
+        if not filename:
+            return None
+        path = resource_filename(
+            self.dataset_project,
+            "setupdata/%s/%s" % (self.dataset_name, filename))
+        try:
+            file_data = read_file(path)
+        except IOError as msg:
+            logger.warning("%s. Error on sheet: %s" % (msg, self.sheetname))
+            return None
+        return NamedBlobImage(
+            data=file_data, filename=api.safe_unicode(filename))
+
     def Import(self):
         laboratory = self.context.setup.laboratory
         values = {}
         for row in self.get_rows(3):
-            values[row['Field']] = row['Value']
-
-        if values['AccreditationBodyLogo']:
-            path = resource_filename(
-                self.dataset_project,
-                "setupdata/%s/%s" % (self.dataset_name,
-                                     values['AccreditationBodyLogo']))
-            try:
-                file_data = read_file(path)
-            except Exception as msg:
-                file_data = None
-                logger.warning(msg[0] + " Error on sheet: " + self.sheetname)
-        else:
-            file_data = None
-
-        laboratory.edit(
-            Name=values['Name'],
-            LabURL=values['LabURL'],
-            Confidence=values['Confidence'],
-            LaboratoryAccredited=self.to_bool(values['LaboratoryAccredited']),
-            AccreditationBodyLong=values['AccreditationBodyLong'],
-            AccreditationBody=values['AccreditationBody'],
-            AccreditationBodyURL=values['AccreditationBodyURL'],
-            Accreditation=values['Accreditation'],
-            AccreditationReference=values['AccreditationReference'],
-            AccreditationBodyLogo=file_data,
-            TaxNumber=values['TaxNumber'],
+            values[row["Field"]] = row["Value"]
+
+        api.edit(
+            laboratory,
+            title=api.safe_unicode(values["Name"]),
+            lab_url=api.safe_unicode(values["LabURL"]),
+            confidence=api.to_int(values["Confidence"], default=None),
+            laboratory_accredited=self.to_bool(
+                values["LaboratoryAccredited"]),
+            accreditation_body=api.safe_unicode(values["AccreditationBody"]),
+            accreditation_body_url=api.safe_unicode(
+                values["AccreditationBodyURL"]),
+            accreditation=api.safe_unicode(values["Accreditation"]),
+            accreditation_reference=api.safe_unicode(
+                values["AccreditationReference"]),
+            accreditation_body_logo=self.get_logo(
+                values["AccreditationBodyLogo"]),
+            tax_number=api.safe_unicode(values["TaxNumber"]),
         )
         self.fill_contactfields(values, laboratory)
         self.fill_addressfields(values, laboratory)