Add DataGridFieldManager to fix UID reference validation in DataGrid fields#91
Open
Tim-IA wants to merge 4 commits into
Open
Add DataGridFieldManager to fix UID reference validation in DataGrid fields#91Tim-IA wants to merge 4 commits into
Tim-IA wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
ZopeSchemaFieldManagerhas no dedicated handling forDataGridField. When a grid row contains aUIDReferenceField, creating objects via the JSON API fails withWrongContainedType, since JSON always delivers unicode (not str) and grid-nestedUIDfields always expect a list, even when multi_valued=False.Current behavior before PR
Desired behavior after PR is merged
New
DataGridFieldManager(ZopeSchemaFieldManager)normalizes UID sub-fields in each row (coerces to list of native str) before delegating to the existing _set().--
I confirm I have tested the PR thoroughly and coded it according to PEP8
standards.