Merge pull request #1438 from sendbird/fix/clnp-8533

[CLNP-8533] fix: detect super group channel via premiumFeatureList

Author: sf-tyler-jeong

src/modules/CreateChannel/__test__/utils.spec.ts

@@ -0,0 +1,72 @@
+import { isBroadcastChannelEnabled, isSuperGroupChannelEnabled } from '../utils';
+import type { SdkStore } from '../../../lib/Sendbird/types';
+
+type Sdk = SdkStore['sdk'];
+
+interface MockAppInfo {
+  applicationAttributes?: string[];
+  premiumFeatureList?: string[];
+}
+
+const mockSdk = (appInfo: MockAppInfo | null): Sdk => ({ appInfo } as unknown as Sdk);
+const noSdk = undefined as unknown as Sdk;
+
+describe('CreateChannel/utils: isSuperGroupChannelEnabled reads premiumFeatureList', () => {
+  it('returns true when premiumFeatureList includes super_group_channel', () => {
+    expect(isSuperGroupChannelEnabled(mockSdk({ premiumFeatureList: ['delivery_receipt', 'super_group_channel'] }))).toBe(true);
+  });
+
+  it('returns false when premiumFeatureList does not include super_group_channel', () => {
+    expect(isSuperGroupChannelEnabled(mockSdk({ premiumFeatureList: ['delivery_receipt'] }))).toBe(false);
+  });
+
+  it('returns false for an empty premiumFeatureList', () => {
+    expect(isSuperGroupChannelEnabled(mockSdk({ premiumFeatureList: [] }))).toBe(false);
+  });
+
+  it('returns false when premiumFeatureList is missing', () => {
+    expect(isSuperGroupChannelEnabled(mockSdk({}))).toBe(false);
+  });
+
+  it('returns false when appInfo is null', () => {
+    expect(isSuperGroupChannelEnabled(mockSdk(null))).toBe(false);
+  });
+
+  it('returns false when sdk is undefined', () => {
+    expect(isSuperGroupChannelEnabled(noSdk)).toBe(false);
+  });
+
+  it('no longer reads the deprecated allow_super_group_channel applicationAttributes flag', () => {
+    expect(isSuperGroupChannelEnabled(mockSdk({ applicationAttributes: ['allow_super_group_channel'], premiumFeatureList: [] }))).toBe(false);
+  });
+});
+
+describe('CreateChannel/utils: isBroadcastChannelEnabled still reads applicationAttributes', () => {
+  it('returns true when applicationAttributes includes allow_broadcast_channel', () => {
+    expect(isBroadcastChannelEnabled(mockSdk({ applicationAttributes: ['allow_broadcast_channel'] }))).toBe(true);
+  });
+
+  it('returns false when applicationAttributes does not include allow_broadcast_channel', () => {
+    expect(isBroadcastChannelEnabled(mockSdk({ applicationAttributes: ['allow_super_group_channel'] }))).toBe(false);
+  });
+
+  it('returns false for an empty applicationAttributes', () => {
+    expect(isBroadcastChannelEnabled(mockSdk({ applicationAttributes: [] }))).toBe(false);
+  });
+
+  it('returns false when applicationAttributes is missing', () => {
+    expect(isBroadcastChannelEnabled(mockSdk({}))).toBe(false);
+  });
+
+  it('returns false when appInfo is null', () => {
+    expect(isBroadcastChannelEnabled(mockSdk(null))).toBe(false);
+  });
+
+  it('returns false when sdk is undefined', () => {
+    expect(isBroadcastChannelEnabled(noSdk)).toBe(false);
+  });
+
+  it('does not read broadcast_channel from premiumFeatureList', () => {
+    expect(isBroadcastChannelEnabled(mockSdk({ premiumFeatureList: ['broadcast_channel'], applicationAttributes: [] }))).toBe(false);
+  });
+});

src/modules/CreateChannel/utils.ts

@@ -1,4 +1,5 @@
 import type { SdkStore } from '../../lib/Sendbird/types';
+import { SUPER_GROUP_CHANNEL } from '../../utils/consts';
 
 export const isBroadcastChannelEnabled = (sdk: SdkStore['sdk']): boolean => {
   const ALLOW_BROADCAST_CHANNEL = 'allow_broadcast_channel';
@@ -12,11 +13,10 @@ export const isBroadcastChannelEnabled = (sdk: SdkStore['sdk']): boolean => {
 };
 
 export const isSuperGroupChannelEnabled = (sdk: SdkStore['sdk']): boolean => {
-  const ALLOW_SUPER_GROUP_CHANNEL = 'allow_super_group_channel';
-  const applicationAttributes = sdk?.appInfo?.applicationAttributes;
+  const premiumFeatureList = sdk?.appInfo?.premiumFeatureList;
 
-  if (Array.isArray(applicationAttributes)) {
-    return applicationAttributes.includes(ALLOW_SUPER_GROUP_CHANNEL);
+  if (Array.isArray(premiumFeatureList)) {
+    return premiumFeatureList.includes(SUPER_GROUP_CHANNEL);
   }
 
   return false;

src/utils/consts.ts

@@ -34,8 +34,9 @@ export const META_ARRAY_VOICE_DURATION_KEY = 'KEY_VOICE_MESSAGE_DURATION';
 export const META_ARRAY_MESSAGE_TYPE_KEY = 'KEY_INTERNAL_MESSAGE_TYPE';
 export const META_ARRAY_MESSAGE_TYPE_VALUE__VOICE = 'voice/mp3';
 
-// delivery receipt in feature list
+// premium feature list keys (appInfo.premiumFeatureList)
 export const DELIVERY_RECEIPT = 'delivery_receipt';
+export const SUPER_GROUP_CHANNEL = 'super_group_channel';
 
 // file viewer slider
 export const SLIDER_BUTTON_ICON_SIDE_LENGTH = '32px';