[CLNP-8533] fix: detect super group channel via premiumFeatureList#1438
Conversation
The server is phasing out the `allow_super_group_channel` flag in `application_attributes`. Update `isSuperGroupChannelEnabled` to read `super_group_channel` from `appInfo.premiumFeatureList`, consistent with how `delivery_receipt` is already detected. `isBroadcastChannelEnabled` is intentionally left on `application_attributes.allow_broadcast_channel`: per the server team it is not exposed through premiumFeatureList and stays ACL-gated. Add a shared SUPER_GROUP_CHANNEL constant in utils/consts.ts and unit tests covering both helpers. Note: release only after the server change ships to all regions, otherwise apps that enabled super group via ACL only would lose the channel type until then. Ref: CLNP-8533 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danney-chun
left a comment
There was a problem hiding this comment.
lgtm~
core-ts 쪽에서는 관련된 내용이 없나요?
core-ts(@sendbird/uikit-tools)에는 관련 상수 정의만 있고, 실제로 그 값을 읽어 super group 활성화 여부를 판단하는 로직은 존재하지 않습니다. 감사합니다~!! 참고로 상수는 2개 정의되어 있습니다.
|
|
core-ts repo에서 수정하고 PR 리뷰 요청 드렸습니다. 감사합니다. |
The server is phasing out the
allow_super_group_channelflag inapplication_attributes. UpdateisSuperGroupChannelEnabledto readsuper_group_channelfromappInfo.premiumFeatureList, consistent with howdelivery_receiptis already detected.isBroadcastChannelEnabledis intentionally left onapplication_attributes.allow_broadcast_channel: per the server team it is not exposed through premiumFeatureList and stays ACL-gated.Add a shared SUPER_GROUP_CHANNEL constant in utils/consts.ts and unit tests covering both helpers.
Note: release only after the server change ships to all regions, otherwise apps that enabled super group via ACL only would lose the channel type until then.
Ref: CLNP-8533
For Internal Contributors
{type}/TICKET_ID/descriptionfeat/fix/chore/doc/releaseTemplate
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can set up a CLA to allow for the contribution.