Skip to content

[CLNP-8533] fix: detect super group channel via premiumFeatureList#1438

Merged
sf-tyler-jeong merged 1 commit into
mainfrom
fix/clnp-8533
Jun 24, 2026
Merged

[CLNP-8533] fix: detect super group channel via premiumFeatureList#1438
sf-tyler-jeong merged 1 commit into
mainfrom
fix/clnp-8533

Conversation

@sf-tyler-jeong

Copy link
Copy Markdown
Contributor

The server is phasing out the allow_super_group_channel flag in application_attributes. Update isSuperGroupChannelEnabled to read super_group_channel from appInfo.premiumFeatureList, consistent with how delivery_receipt is already detected.

isBroadcastChannelEnabled is intentionally left on application_attributes.allow_broadcast_channel: per the server team it is not exposed through premiumFeatureList and stays ACL-gated.

Add a shared SUPER_GROUP_CHANNEL constant in utils/consts.ts and unit tests covering both helpers.

Note: release only after the server change ships to all regions, otherwise apps that enabled super group via ACL only would lose the channel type until then.

Ref: CLNP-8533

For Internal Contributors

  • Follow the Scaled Trunk-Based Development workflow
  • Branch naming format: {type}/TICKET_ID/description
    • Type: feat / fix / chore / doc / release
  • Receive PR review approvals
  • Rebase your branch with the main branch and wait for CI to pass
  • Squash merge your commit
    • Use imperative language in the title and description
    • Follow the provided template for PR description and squashing

Template

// PR title (Required)
[type]: A short description of the changes in imperative language.

// PR description (Optional)
Add a brief description of the changes in this PR. Bullet points are also fine.

// Footer (Recommended)
Fixes [<TICKET_ID>](https://sendbird.atlassian.net/browse/<TICKET_ID>)

// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.
### Changelogs

// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name name@example.com, Name2 name@example.com

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

The server is phasing out the `allow_super_group_channel` flag in
`application_attributes`. Update `isSuperGroupChannelEnabled` to read
`super_group_channel` from `appInfo.premiumFeatureList`, consistent with
how `delivery_receipt` is already detected.

`isBroadcastChannelEnabled` is intentionally left on
`application_attributes.allow_broadcast_channel`: per the server team it
is not exposed through premiumFeatureList and stays ACL-gated.

Add a shared SUPER_GROUP_CHANNEL constant in utils/consts.ts and unit
tests covering both helpers.

Note: release only after the server change ships to all regions,
otherwise apps that enabled super group via ACL only would lose the
channel type until then.

Ref: CLNP-8533

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@netlify

netlify Bot commented Jun 15, 2026

Copy link
Copy Markdown

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 5595e22
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/6a2f5d726a66dc000834f0b2
😎 Deploy Preview https://deploy-preview-1438--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danney-chun danney-chun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~
core-ts 쪽에서는 관련된 내용이 없나요?

@sf-tyler-jeong

Copy link
Copy Markdown
Contributor Author

lgtm~ core-ts 쪽에서는 관련된 내용이 없나요?

core-ts(@sendbird/uikit-tools)에는 관련 상수 정의만 있고, 실제로 그 값을 읽어 super group 활성화 여부를 판단하는 로직은 존재하지 않습니다. 감사합니다~!!

참고로 상수는 2개 정의되어 있습니다.

  • constants/applicationAttributes.ts → allow_super_group_channel: 'allow_super_group_channel'
  • constants/premiumFeatures.ts → super_group_channel: 'super_group_channel'

@danney-chun

Copy link
Copy Markdown
Contributor

lgtm~ core-ts 쪽에서는 관련된 내용이 없나요?

core-ts(@sendbird/uikit-tools)에는 관련 상수 정의만 있고, 실제로 그 값을 읽어 super group 활성화 여부를 판단하는 로직은 존재하지 않습니다. 감사합니다~!!

참고로 상수는 2개 정의되어 있습니다.

  • constants/applicationAttributes.ts → allow_super_group_channel: 'allow_super_group_channel'
  • constants/premiumFeatures.ts → super_group_channel: 'super_group_channel'

allow_super_group_channel 가 필요 없다면, core-ts에서도 빠져 있는게 좋을거 같습니다.

@sf-tyler-jeong

Copy link
Copy Markdown
Contributor Author

lgtm~ core-ts 쪽에서는 관련된 내용이 없나요?

core-ts(@sendbird/uikit-tools)에는 관련 상수 정의만 있고, 실제로 그 값을 읽어 super group 활성화 여부를 판단하는 로직은 존재하지 않습니다. 감사합니다~!!
참고로 상수는 2개 정의되어 있습니다.

  • constants/applicationAttributes.ts → allow_super_group_channel: 'allow_super_group_channel'
  • constants/premiumFeatures.ts → super_group_channel: 'super_group_channel'

allow_super_group_channel 가 필요 없다면, core-ts에서도 빠져 있는게 좋을거 같습니다.

core-ts repo에서 수정하고 PR 리뷰 요청 드렸습니다. 감사합니다.

@sf-tyler-jeong sf-tyler-jeong merged commit dda4e50 into main Jun 24, 2026
8 checks passed
@sf-tyler-jeong sf-tyler-jeong deleted the fix/clnp-8533 branch June 24, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants