Added Commitlint and Changelog#18
Conversation
also added Commitizen for easily writing commit messages ISSUES CLOSED: sendilkumarn#10
Symphoria
force-pushed
the
enhance/commitlint
branch
from
f01b846 to
3509028
Compare
|
|
||
| ## New Features | ||
|
|
||
| * add circle ci batch ([626fa2f](https://github.com/Symphoria/webpack-addons-pwa/commit/626fa2f)) |
There was a problem hiding this comment.
Can you change the repo to point upstream sendilkumarn/webpack-addons-pw?
|
@sendilkumarn @dhruvdutt Made the changes. Please review |
dhruvdutt
left a comment
dhruvdutt
left a comment
There was a problem hiding this comment.
LGTM except for some minor changes. 👍
| scopes: [], | ||
| types: [ | ||
| { value: "feat", name: "feat: A new feature" }, | ||
| { value: "tests", name: "tests: Tests, jest, binTestCases, etc" }, |
There was a problem hiding this comment.
We don't use jest. Also, you can clear binTestCases.
| { value: "tests", name: "tests: Tests, jest, binTestCases, etc" }, | ||
| { value: "docs", name: "docs: Documentation" }, | ||
| { value: "misc", name: "misc: Other formats like tweaks and such" }, | ||
| { value: "chore", name: "chore: Updating docs, linting, grunt tasks etc" }, |
dhruvdutt
left a comment
dhruvdutt
left a comment
There was a problem hiding this comment.
LGTM 💯 @Symphoria Going good.
| @@ -0,0 +1 @@ | |||
| build No newline at end of file | |||
There was a problem hiding this comment.
add one more blank line here
| @@ -0,0 +1,86 @@ | |||
| <a name="1.0.0"></a> | |||
| # 1.0.0 (2018-03-10) | |||
There was a problem hiding this comment.
Actually, 1.0.0 is the version specified in package.json. Do I increase the version in package.json? @sendilkumarn
| process.stderr.write(` | ||
| > Be sure to have the latest git tags locally: | ||
| git fetch --tags | ||
|
|
|
@Symphoria did you plan to work on this ? |
|
@Symphoria @sendilkumarn there are few minor changes left in this PR, would be nice if this PR is resolved!! |
4 participants
No description provided.