Fix setup assist entity lookup failure status

Author: senyo888

helpers/setup_assist.py

@@ -106,7 +106,7 @@ def setup_assist_suggestion(
             clean_entity_id,
             err,
         )
-        entity_entry = None
+        return unsupported_setup_assist_suggestion("entity_lookup_failed", clean_entity_id)
     if entity_entry is None:
         return SetupAssistSuggestion(entity_id=clean_entity_id, status="not_found")
 

tests 2/test_setup_assist.py

@@ -182,6 +182,28 @@ def test_setup_assist_logs_registry_failures_without_changing_fallback():
     debug.assert_called()
 
 
+def test_setup_assist_entity_lookup_failure_is_not_reported_as_missing():
+    setup_assist = _load_setup_assist_module()
+
+    class BrokenEntityRegistry:
+        def async_get(self, _entity_id):
+            raise RuntimeError("entity lookup exploded")
+
+    hass = SimpleNamespace(entities={}, devices={}, areas={}, labels={})
+    with (
+        mock.patch.object(setup_assist.er, "async_get", return_value=BrokenEntityRegistry()),
+        mock.patch.object(setup_assist._LOGGER, "debug") as debug,
+    ):
+        suggestion = setup_assist.setup_assist_suggestion(
+            hass,
+            "sensor.example_humidity",
+        )
+
+    assert suggestion.status == "unsupported"
+    assert suggestion.warnings == ("entity_lookup_failed",)
+    debug.assert_called()
+
+
 if __name__ == "__main__":
     tests = [
         (name, value)