From d1f631416745b1a8008a4222b88bf496ed0e64f1 Mon Sep 17 00:00:00 2001 From: Sam <109683132+kernelsam@users.noreply.github.com> Date: Fri, 13 Mar 2026 12:27:35 -0700 Subject: [PATCH 1/2] #348 Migrate workflows to centralized SDK version matrix and fix job outputs --- .github/workflows/pylint.yaml | 6 ++---- .github/workflows/pytest-darwin.yaml | 11 ++++++++++- .github/workflows/pytest-linux.yaml | 11 ++++++++++- .github/workflows/pytest-windows.yaml | 11 ++++++++++- 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pylint.yaml b/.github/workflows/pylint.yaml index 62252d6..7e82f5a 100644 --- a/.github/workflows/pylint.yaml +++ b/.github/workflows/pylint.yaml @@ -12,8 +12,6 @@ permissions: {} jobs: pylint: - outputs: - status: ${{ job.status }} permissions: contents: read runs-on: ubuntu-latest @@ -49,10 +47,10 @@ jobs: slack-notification: needs: [pylint] - if: ${{ always() && contains(fromJSON('["failure", "cancelled"]'), needs.pylint.outputs.status ) && github.ref_name == github.event.repository.default_branch }} + if: ${{ always() && contains(fromJSON('["failure", "cancelled"]'), needs.pylint.result ) && github.ref_name == github.event.repository.default_branch }} secrets: SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }} SLACK_CHANNEL: ${{ secrets.SLACK_CHANNEL }} uses: senzing-factory/build-resources/.github/workflows/build-failure-slack-notification.yaml@v4 with: - job-status: ${{ needs.pylint.outputs.status }} + job-status: ${{ needs.pylint.result }} diff --git a/.github/workflows/pytest-darwin.yaml b/.github/workflows/pytest-darwin.yaml index 2eab035..d4e684f 100644 --- a/.github/workflows/pytest-darwin.yaml +++ b/.github/workflows/pytest-darwin.yaml @@ -18,8 +18,17 @@ env: permissions: {} jobs: + + sdk-versions: + runs-on: ubuntu-latest + outputs: + senzingsdk-versions: ${{ steps.cfg.outputs.senzingsdk-versions }} + steps: + - id: cfg + uses: senzing-factory/build-resources/sdk-versions@v4 pytest-darwin: name: "Pytest with Senzing: ${{ matrix.senzingsdk-version }}; OS: ${{ matrix.os }}; Python ${{ matrix.python-version }}" + needs: sdk-versions permissions: contents: read runs-on: ${{ matrix.os }} @@ -28,7 +37,7 @@ jobs: matrix: os: [macos-latest] python-version: ["3.10", "3.11", "3.12", "3.13"] - senzingsdk-version: [production-v4, staging-v4] + senzingsdk-version: ${{ fromJSON(needs.sdk-versions.outputs.senzingsdk-versions) }} timeout-minutes: 30 steps: diff --git a/.github/workflows/pytest-linux.yaml b/.github/workflows/pytest-linux.yaml index c24ff76..6a041be 100644 --- a/.github/workflows/pytest-linux.yaml +++ b/.github/workflows/pytest-linux.yaml @@ -20,8 +20,17 @@ env: permissions: {} jobs: + + sdk-versions: + runs-on: ubuntu-latest + outputs: + senzingsdk-versions: ${{ steps.cfg.outputs.senzingsdk-versions }} + steps: + - id: cfg + uses: senzing-factory/build-resources/sdk-versions@v4 pytest-linux: name: "Pytest with Senzing: ${{ matrix.senzingsdk-version }}; OS: ${{ matrix.os }}; Python ${{ matrix.python-version }}" + needs: sdk-versions permissions: contents: read runs-on: ${{ matrix.os }} @@ -30,7 +39,7 @@ jobs: matrix: os: [ubuntu-latest] python-version: ["3.10", "3.11", "3.12", "3.13"] - senzingsdk-version: [production-v4, staging-v4] + senzingsdk-version: ${{ fromJSON(needs.sdk-versions.outputs.senzingsdk-versions) }} timeout-minutes: 30 steps: diff --git a/.github/workflows/pytest-windows.yaml b/.github/workflows/pytest-windows.yaml index 87dd4d3..d451b2f 100644 --- a/.github/workflows/pytest-windows.yaml +++ b/.github/workflows/pytest-windows.yaml @@ -18,8 +18,17 @@ env: permissions: {} jobs: + + sdk-versions: + runs-on: ubuntu-latest + outputs: + senzingsdk-versions: ${{ steps.cfg.outputs.senzingsdk-versions }} + steps: + - id: cfg + uses: senzing-factory/build-resources/sdk-versions@v4 pytest-windows: name: "Pytest with Senzing: ${{ matrix.senzingsdk-version }}; OS: windows-latest; Python ${{ matrix.python-version }}" + needs: sdk-versions permissions: contents: read runs-on: windows-latest @@ -27,7 +36,7 @@ jobs: fail-fast: false matrix: python-version: ["3.10", "3.11", "3.12", "3.13"] - senzingsdk-version: [production-v4, staging-v4] + senzingsdk-version: ${{ fromJSON(needs.sdk-versions.outputs.senzingsdk-versions) }} timeout-minutes: 30 steps: From d48b3b153ccd1419a62ee83b708cda07b42bc4b6 Mon Sep 17 00:00:00 2001 From: Sam <109683132+kernelsam@users.noreply.github.com> Date: Fri, 13 Mar 2026 12:40:51 -0700 Subject: [PATCH 2/2] fix: formatting and zizmor template-injection warnings --- .github/workflows/pytest-darwin.yaml | 2 +- .github/workflows/pytest-linux.yaml | 2 +- .github/workflows/pytest-windows.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pytest-darwin.yaml b/.github/workflows/pytest-darwin.yaml index d4e684f..14398ba 100644 --- a/.github/workflows/pytest-darwin.yaml +++ b/.github/workflows/pytest-darwin.yaml @@ -18,7 +18,6 @@ env: permissions: {} jobs: - sdk-versions: runs-on: ubuntu-latest outputs: @@ -26,6 +25,7 @@ jobs: steps: - id: cfg uses: senzing-factory/build-resources/sdk-versions@v4 + pytest-darwin: name: "Pytest with Senzing: ${{ matrix.senzingsdk-version }}; OS: ${{ matrix.os }}; Python ${{ matrix.python-version }}" needs: sdk-versions diff --git a/.github/workflows/pytest-linux.yaml b/.github/workflows/pytest-linux.yaml index 6a041be..6746b59 100644 --- a/.github/workflows/pytest-linux.yaml +++ b/.github/workflows/pytest-linux.yaml @@ -20,7 +20,6 @@ env: permissions: {} jobs: - sdk-versions: runs-on: ubuntu-latest outputs: @@ -28,6 +27,7 @@ jobs: steps: - id: cfg uses: senzing-factory/build-resources/sdk-versions@v4 + pytest-linux: name: "Pytest with Senzing: ${{ matrix.senzingsdk-version }}; OS: ${{ matrix.os }}; Python ${{ matrix.python-version }}" needs: sdk-versions diff --git a/.github/workflows/pytest-windows.yaml b/.github/workflows/pytest-windows.yaml index d451b2f..e5dd7ba 100644 --- a/.github/workflows/pytest-windows.yaml +++ b/.github/workflows/pytest-windows.yaml @@ -18,7 +18,6 @@ env: permissions: {} jobs: - sdk-versions: runs-on: ubuntu-latest outputs: @@ -26,6 +25,7 @@ jobs: steps: - id: cfg uses: senzing-factory/build-resources/sdk-versions@v4 + pytest-windows: name: "Pytest with Senzing: ${{ matrix.senzingsdk-version }}; OS: windows-latest; Python ${{ matrix.python-version }}" needs: sdk-versions