Skip to content

feat: disable trusted section swipeable#320

Open
fzn0x wants to merge 2 commits intomainfrom
disable-swipeable-clickable
Open

feat: disable trusted section swipeable#320
fzn0x wants to merge 2 commits intomainfrom
disable-swipeable-clickable

Conversation

@fzn0x
Copy link
Copy Markdown
Member

@fzn0x fzn0x commented Oct 26, 2022

Closes #166

@fzn0x fzn0x requested a review from sdepold October 26, 2022 09:50
@fzn0x fzn0x self-assigned this Oct 26, 2022
@fzn0x fzn0x requested a review from WikiRik October 26, 2022 09:52
@github-actions
Copy link
Copy Markdown

@ephys
Copy link
Copy Markdown
Member

ephys commented Oct 26, 2022

I think we should update the testimonial instead of disabling these

@fzn0x
Copy link
Copy Markdown
Member Author

fzn0x commented Oct 26, 2022

I think we should update the testimonial instead of disabling these

Is creating a new testimonial section a wise change?

@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Oct 27, 2022

I think what Zoé means is that we should fix the issue instead of just disabling part of it. So make sure that the testimonials update when clicking on other logos and that the first one does not lead to the last one

@fzn0x
Copy link
Copy Markdown
Member Author

fzn0x commented Oct 27, 2022

I think what Zoé means is that we should fix the issue instead of just disabling part of it. So make sure that the testimonials update when clicking on other logos and that the first one does not lead to the last one

Ahh I see, thanks

@ephys
Copy link
Copy Markdown
Member

ephys commented Nov 9, 2022

Yep. Re-reading my comment I see how ambiguous it is :)

@fzn0x fzn0x requested a review from a team as a code owner April 11, 2024 20:17
@fzn0x fzn0x requested a review from ephys April 11, 2024 20:17
@github-actions
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Minor bug] Testimonial navigation broken

3 participants