Skip to content

feat: Metrics tracking for network management#404

Draft
Tw1ZZLER wants to merge 125 commits into
masterfrom
metrics-network
Draft

feat: Metrics tracking for network management#404
Tw1ZZLER wants to merge 125 commits into
masterfrom
metrics-network

Conversation

@Tw1ZZLER

@Tw1ZZLER Tw1ZZLER commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Add new EventTypes RESERVATION_APPROVED, RESERVATION_REJECTED, and RESERVATION_COMPLETION, as well as THROUGHPUT for the modified throughput metric. Throughput and reservation start time have been removed from the minimized CollectContext (that we are trying to do away with altogether) and are now based on existing metrics. It is worth noting that the collect method of RateMetric has been adjusted to quite literally copy and completely replace RequestApp.get_throughput(). It has also been renamed to ThroughputMetric as result.

Tw1ZZLER added 30 commits June 18, 2026 15:25
I don't know if 2 Timelines will ever exist at once, but if so then this
might be a problem. For now it seems to be an okay solution
Comment thread sequence/utils/metrics/builtins.py Fixed
@github-code-quality

github-code-quality Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall coverage in the branch is 84%. The coverage in the branch is 83%.

Show a code coverage summary of the most impacted files.
File 021ef42 696e409 +/-
sequence/kernel...r/stabilizer.py 76% 76% 0%
tests/network_m...work_manager.py 98% 98% 0%
sequence/entang...n/bbpssw_bds.py 48% 48% 0%
sequence/utils/...ics/registry.py 0% 78% +78%
sequence/utils/.../event_types.py 0% 96% +96%
sequence/utils/...metric_types.py 0% 97% +97%
sequence/utils/...ics/__init__.py 0% 97% +97%
tests/utils/test_metrics.py 0% 100% +100%
sequence/utils/...ics/builtins.py 0% 100% +100%
sequence/utils/...rics/storage.py 0% 100% +100%

Updated July 10, 2026 16:55 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@hayekr
hayekr requested a review from bedolpab July 8, 2026 17:32
@hayekr
hayekr marked this pull request as draft July 14, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants