Skip to content

feat: Add App abstraction class to standardize API and add hooks#418

Merged
Tw1ZZLER merged 12 commits into
masterfrom
app-abstraction
Jul 17, 2026
Merged

feat: Add App abstraction class to standardize API and add hooks#418
Tw1ZZLER merged 12 commits into
masterfrom
app-abstraction

Conversation

@Tw1ZZLER

@Tw1ZZLER Tw1ZZLER commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a new abstract class App that other apps such as RequestApp and PeriodicApp now inherit from. It includes 3 new abstract methods that are required to be meaningfully implemented in the subclasses of App. These are get_memory(), get_reservation_result(), and get_other_reservation().

@github-code-quality

github-code-quality Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall coverage in the branch remains at 83%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File 021ef42 0e8016b +/-
sequence/entang...n/bbpssw_bds.py 48% 48% 0%
sequence/app/request_app.py 99% 100% +1%
sequence/utils/.../event_types.py 0% 81% +81%
sequence/app/app.py 0% 81% +81%
sequence/utils/...ics/registry.py 0% 87% +87%
sequence/utils/...ics/__init__.py 0% 97% +97%
sequence/utils/...metric_types.py 0% 98% +98%
tests/utils/test_metrics.py 0% 100% +100%
sequence/utils/...rics/storage.py 0% 100% +100%
sequence/utils/...ics/builtins.py 0% 100% +100%

Updated July 17, 2026 18:06 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

Comment thread sequence/app/app.py Fixed
Comment thread sequence/app/app.py Fixed
Tw1ZZLER and others added 2 commits July 13, 2026 14:37
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Comment thread sequence/app/app.py Fixed
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@Tw1ZZLER

Copy link
Copy Markdown
Collaborator Author

Removed get_throughput(). If the user wants throughput from the app they should use THROUGHPUT_METRIC. Ideally get_throughput() should be deprecated

Comment thread sequence/app/app.py Outdated
Comment thread sequence/app/app.py
Comment thread sequence/app/app.py
Comment thread sequence/app/__init__.py
@Tw1ZZLER

Copy link
Copy Markdown
Collaborator Author

Added warning that get_throughput() is deprecated and THROUGHPUT_METRIC should be used instead.

should be ready for merge 🙂

@Tw1ZZLER
Tw1ZZLER merged commit 17e7401 into master Jul 17, 2026
16 checks passed
@Tw1ZZLER
Tw1ZZLER deleted the app-abstraction branch July 17, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants