feat: Add App abstraction class to standardize API and add hooks#418
Merged
Conversation
Tw1ZZLER
requested review from
Alex-Kolar,
JoaquinChung,
caitaozhan and
hayekr
as code owners
July 13, 2026 19:28
Contributor
Code Coverage OverviewLanguages: Python Python / code-coverage/pytestThe overall coverage in the branch remains at 83%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Collaborator
Author
|
Removed |
hayekr
reviewed
Jul 16, 2026
caitaozhan
reviewed
Jul 17, 2026
Collaborator
Author
|
Added warning that should be ready for merge 🙂 |
hayekr
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new abstract class
Appthat other apps such asRequestAppandPeriodicAppnow inherit from. It includes 3 new abstract methods that are required to be meaningfully implemented in the subclasses of App. These areget_memory(),get_reservation_result(), andget_other_reservation().