fix: Data restore fails on managed PostgreSQL services

Remove --disable-triggers and --jobs=N from pg_restore. The v7.0.8 fix
for FK constraint violations required superuser privileges that managed
PostgreSQL services (SerenDB, AWS RDS, Neon) don't grant.

Single-threaded restore naturally respects FK dependency order, avoiding
the need for elevated privileges while ensuring data integrity.

Closes #73

Author: taariq

CHANGELOG.md

@@ -2,6 +2,16 @@
 
 All notable changes to this project will be documented in this file.
 
+## [7.0.9] - 2025-12-10
+
+### Fixed
+
+- **Data restore fails on managed PostgreSQL services**: Fixed bug where `pg_restore` would fail with "permission denied: system trigger" on managed PostgreSQL services (SerenDB, AWS RDS, Neon, etc.). The v7.0.8 fix for FK constraint violations used `--disable-triggers`, which requires superuser privileges that managed services don't grant. Replaced parallel restore with single-threaded restore that naturally respects FK dependency order, eliminating the need for elevated privileges.
+
+### Changed
+
+- **Removed parallel restore**: Data restoration now uses single-threaded `pg_restore` instead of parallel (`--jobs=N`). This is slower but works on all PostgreSQL deployments without requiring superuser privileges. The trade-off is acceptable since correctness and compatibility are prioritized over speed.
+
 ## [7.0.8] - 2025-12-09
 
 ### Fixed

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "database-replicator"
-version = "7.0.8"
+version = "7.0.9"
 edition = "2021"
 license = "Apache-2.0"
 description = "Universal database-to-PostgreSQL replication CLI. Supports PostgreSQL, SQLite, MongoDB, and MySQL."

Cargo.toml

@@ -171,14 +171,22 @@ pub async fn restore_schema(target_url: &str, input_path: &str) -> Result<()> {
     Ok(())
 }
 
-/// Restore data using pg_restore with parallel jobs
+/// Restore data using pg_restore
 ///
 /// Uses PostgreSQL directory format restore with:
-/// - Parallel restore for faster performance
+/// - Single-threaded restore to respect FK dependency order
 /// - Automatic decompression of compressed dump files
 /// - Optimized for directory format dumps created by dump_data()
 ///
-/// The number of parallel jobs is automatically determined based on available CPU cores.
+/// # Why Single-Threaded?
+///
+/// Parallel restore (`--jobs=N`) requires `--disable-triggers` to avoid FK
+/// constraint violations when tables are restored out of dependency order.
+/// However, `--disable-triggers` requires superuser privileges, which managed
+/// PostgreSQL services (SerenDB, AWS RDS, Neon, etc.) do not grant.
+///
+/// Single-threaded restore naturally processes tables in FK dependency order,
+/// avoiding the need for elevated privileges while ensuring data integrity.
 ///
 /// # Note on Retry Behavior
 ///
@@ -189,16 +197,7 @@ pub async fn restore_schema(target_url: &str, input_path: &str) -> Result<()> {
 /// If data restoration fails due to connection issues, the user should re-run the
 /// command with --drop-existing to ensure a clean slate.
 pub async fn restore_data(target_url: &str, input_path: &str) -> Result<()> {
-    // Determine optimal number of parallel jobs (number of CPUs, capped at 8)
-    let num_cpus = std::thread::available_parallelism()
-        .map(|n| n.get().min(8))
-        .unwrap_or(4);
-
-    tracing::info!(
-        "Restoring data from {} (parallel={}, format=directory)",
-        input_path,
-        num_cpus
-    );
+    tracing::info!("Restoring data from {} (format=directory)", input_path);
 
     // Parse URL and create .pgpass file for secure authentication
     let parts = crate::utils::parse_postgres_url(target_url)
@@ -218,8 +217,6 @@ pub async fn restore_data(target_url: &str, input_path: &str) -> Result<()> {
     let mut cmd = Command::new("pg_restore");
     cmd.arg("--data-only")
         .arg("--no-owner")
-        .arg("--disable-triggers") // Disable FK constraints during parallel restore
-        .arg(format!("--jobs={}", num_cpus)) // Parallel restore jobs
         .arg("--host")
         .arg(&parts.host)
         .arg("--port")
@@ -277,10 +274,7 @@ pub async fn restore_data(target_url: &str, input_path: &str) -> Result<()> {
         );
     }
 
-    tracing::info!(
-        "✓ Data restored successfully using {} parallel jobs",
-        num_cpus
-    );
+    tracing::info!("✓ Data restored successfully");
     Ok(())
 }