Added minimal support for FTP with TLS/SSL

[jayagl]

Tested only over FTP with implicit TLS/SSL encryption.
Operations tested - ls(), get().

[jayagl]

Sorry this is very minimal, but it doesn't break any of the previous functionality and provides FTP with TLS in a very simple form.

• The init config needs a param called 'ssl' set to true. It will then create the socket using TLS. Also takes a secondary 'sslOptions' object in the config to pass to tls.connect().
• I was having trouble getting files over a secure connection and getting a 522 FTP error. But I managed to get around that by explicitly running the 'prot p' command on connect to specify that the data channel is protected. Not sure if this is applicable to all cases but it worked for mine.
  I am on a deadline here, so didn't have time to update tests or docs.

[sergi]

Hi @jayagl. Can you include tests in your PR? Thanks!

[jayagl]

Hi @sergi, I figured it would be best to run all the pre-existing tests with SSL enabled. I've added some code to do that. I also made some other minor changes to the test file to be more cross-platform friendly. I had lots of trouble running tests in my local environment: with windows filesystem things; creating an FTP server (resorted to running a server externally); with before/after hooks, etc.

[sergi]

nit: space between if and (

[dcolens]

do you plan to merge this request ?

[Philipp91]

For me, this code is working. The normal (non-secure) test suite runs up to "test invalid password" and after that it fails for reasons I haven't yet investigated. When I then apply this pull request and use the same server (that also supports explicit FTPS, but not implicit FTPS by the way) then the test suite runs in the same way and crashes at the same place.

It would be great to see this integrated, as that would make FTPS available in the Brackets code editor through the eqFTP plugin. If that helps, I can provide a temporary FTPS test account on my server for testing.

[dustinbolton]

Any hope of this making it in? It would be lovely to have.

[jayagl]

I've created another PR with more concise changes to the latest version.