Added Downloadable Windows Script#626
Closed
SenkaWolf wants to merge 37 commits into
Closed
Conversation
Add optional code param in upload request
Bumps [twig/twig](https://github.com/twigphp/Twig) from 2.16.0 to 2.16.1. - [Changelog](https://github.com/twigphp/Twig/blob/v2.16.1/CHANGELOG) - [Commits](twigphp/Twig@v2.16.0...v2.16.1) --- updated-dependencies: - dependency-name: twig/twig dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
enable custom sender via 'app_email' in the config.php
…g/twig-2.16.1 Bump twig/twig from 2.16.0 to 2.16.1
Currently translated at 99.3% (161 of 162 strings) Translation: XBackBone/XBackBone Translate-URL: https://hosted.weblate.org/projects/xbackbone/xbackbone/sr/
Translations update from Hosted Weblate
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.1 to 5.0.0. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v4.6.1...v5.0.0) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [twig/twig](https://github.com/twigphp/Twig) from 2.16.1 to 3.11.2. - [Changelog](https://github.com/twigphp/Twig/blob/v3.11.2/CHANGELOG) - [Commits](twigphp/Twig@v2.16.1...v3.11.2) --- updated-dependencies: - dependency-name: twig/twig dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…g/twig-3.11.2 Bump twig/twig from 2.16.1 to 3.11.2
Exporting ShareX settings now work for the latest version of ShareX 16.1.0. "unsupported custom uploader" Error Fix
Exporting ShareX Settings Fix
Add an app_email option to the config
[ci skip] [skip ci]
Apply fixes from StyleCI
…/bootstrap-5.0.0 Bump bootstrap from 4.6.1 to 5.0.0
…omposer/twig/twig-3.11.2 Revert "Bump twig/twig from 2.16.1 to 3.11.2"
Bumps [twig/twig](https://github.com/twigphp/Twig) from 2.16.1 to 3.11.2. - [Changelog](https://github.com/twigphp/Twig/blob/3.x/CHANGELOG) - [Commits](twigphp/Twig@v2.16.1...v3.11.2) --- updated-dependencies: - dependency-name: twig/twig dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…g/twig-3.11.2 Bump twig/twig from 2.16.1 to 3.11.2
Currently translated at 100.0% (162 of 162 strings) Translation: XBackBone/XBackBone Translate-URL: https://hosted.weblate.org/projects/xbackbone/xbackbone/ru/
Currently translated at 100.0% (162 of 162 strings) Translation: XBackBone/XBackBone Translate-URL: https://hosted.weblate.org/projects/xbackbone/xbackbone/ta/
Currently translated at 100.0% (162 of 162 strings) Translation: XBackBone/XBackBone Translate-URL: https://hosted.weblate.org/projects/xbackbone/xbackbone/pt/
Currently translated at 99.3% (161 of 162 strings) Translation: XBackBone/XBackBone Translate-URL: https://hosted.weblate.org/projects/xbackbone/xbackbone/fi/
Currently translated at 100.0% (162 of 162 strings) Translation: XBackBone/XBackBone Translate-URL: https://hosted.weblate.org/projects/xbackbone/xbackbone/id/
Translations update from Hosted Weblate
Added downloadable 'Send to' Windows Context Menu script as requested in sergix44#580 . All .bat code provided by https://github.com/Sectly Preview: https://senkawolf.fyi/me/RUgOWoQI51.png
Contributor
|
Very nice hope it gets added to release as soon as possible 😄 |
sergix44
requested changes
Jan 23, 2025
| $fileName = $fileBaseName . '.bat'; // Full file name with extension | ||
|
|
||
| // Prepare the content of the .txt file | ||
| $batscript = '@echo off' . PHP_EOL; |
Owner
There was a problem hiding this comment.
🔨 issue: Can you please put the script in a proper template like for the others? This is very hard to understand and maintain
| $batscript .= ':CreateSendToShortcut' . PHP_EOL; | ||
| $batscript .= 'set "ShortcutName=Upload to ' .$appName. ' (@'.$user->username.').lnk"' . PHP_EOL; | ||
| $batscript .= 'set "ShortcutPath=%APPDATA%\\Microsoft\\Windows\\SendTo\\%ShortcutName%"' . PHP_EOL; | ||
| $batscript .= 'set "IconUrl=https://xbackbone.app/favicon.ico"' . PHP_EOL; |
Owner
There was a problem hiding this comment.
🔨 issue: This shuld point to the current instance, not the xbb website.
Comment on lines
+74
to
+75
| $config = include __DIR__ . '/../../config.php'; // Adjust the path as necessary | ||
| $appName = $config['app_name'] ?? 'XBackBone'; // Provide a default if not set |
Owner
There was a problem hiding this comment.
🔨 issue: config must be fetch from the container, as it can be altered during bootstrapping. The config file is never read during the app runtime
Contributor
|
You can use my contribution I made a year ago as an guide and example to fix for all these issues Sergi mentioned. Sorry if it is a little hard to read, it is a limitation with how KDE handles shell commands. Found here: #554. Good luck :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added downloadable 'Send to' Windows Context Menu script as requested in #580 . All .bat code provided by https://github.com/Sectly
Preview: https://senkawolf.fyi/me/RUgOWoQI51.png