Align test block with goreleaser: offline-only assertions#1
Closed
Align test block with goreleaser: offline-only assertions#1
Conversation
Replace 7 network-dependent assertions with 5 offline-only ones. Network tests fail in Homebrew sandbox environments. New tests only verify behavior that requires no outbound connections: - version string injection - --help output - no-key account/archive exit 2 - invalid archive ID format exit 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goreleaser config was updated in serpapi/serpapi-cli#2 to use 5 offline-only brew test assertions (network calls fail in Homebrew sandbox environments). This PR aligns the tap formula test block to match.
Removed (network-dependent):
serpapi search q=coffee(unauthenticated API call)--api-key invalid search q=coffee(live error check)--api-key invalid account(live error check)serpapi locations q=Austin(live API call)--api-key invalid archive abc123(live error check)Kept / Added (fully offline):
--helpoutputNote:
url/sha256still point to v0.1.1 — goreleaser will auto-update them when v0.2.0 is tagged.