Support XML Namespaces#23
Open
takahashim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Nokogiri-style XML Namespace API to Nokolexbor.
Lexbor already keeps namespace information internally; this PR exposes that information through Nokolexbor's Ruby API and makes it available to XPath namespace resolution.
This enables proper handling of HTML documents that contain SVG, MathML, or other namespaced content.
Example
Compatibility
This PR adds support for the common Nokogiri namespace APIs in Nokolexbor:
Nokolexbor::Namespaceprovidesprefix,href, anddocument, mirroringNokogiri::XML::Namespace.Node#namespace,#namespace_scopes,#namespaces,#namespace_definitions, and#add_namespace_definitionprovide Nokogiri-compatible namespace accessors.at_xpath("//svg:circle", "svg" => "..."), now work for elements in default namespaces such asxmlns="http://www.w3.org/2000/svg".The changes are additive. No existing Nokolexbor API is intentionally changed.