Skip to content

update CI configuration to include Ruby 2.7 in the testing matrix #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvmvik wants to merge 12 commits into from
Closed

update CI configuration to include Ruby 2.7 in the testing matrix #8

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e5be70b
update CI configuration to include Ruby 2.7 in the testing matrix
jvmvik Aug 6, 2025
6b3b797
update gitaction to match the latest instruction from github.com/ruby…
jvmvik Aug 11, 2025
28b98d2
fix a typo i
jvmvik Aug 11, 2025
d7241a8
add newly required rubocop-rake dependency
jvmvik Aug 11, 2025
3a88351
remove version of rubocop to simplify multiple ruby version compatibi…
jvmvik Aug 11, 2025
cfc6acc
enable rake plugin for rubocop
jvmvik Aug 11, 2025
8795607
explicitly set link add rubocop-rake dependency
jvmvik Aug 11, 2025
af98ea3
fix bad syntax proposed by ChatGPT
jvmvik Aug 11, 2025
f38de9c
rake call rubocop directly
jvmvik Aug 12, 2025
7cf9a02
update Ruby version in CI configuration to 2.7.8 and set Bundler vers…
jvmvik Aug 12, 2025
53374b2
ruby 3.5 is not compatible with rubocop
jvmvik Aug 12, 2025
6b64a48
add panolint dependency, remote rubocop-rake requirement
jvmvik Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.1.0','head'] # test only recommend Ruby version (and stable version on the gitaction server)
# ruby-version: ['2.7.4','3.1.0','head']
ruby-version: ['2.7', '3.1.0','head'] # test only recommend Ruby version (and stable version on the gitaction server)
Copy link
Copy Markdown
Contributor

@ocvit ocvit Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more explicit and check all supported Ruby versions.

Suggested change
ruby-version: ['2.7', '3.1.0','head'] # test only recommend Ruby version (and stable version on the gitaction server)
ruby-version: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4", "head"] # check all supported Ruby versions, plus the latest stable one

Copy link
Copy Markdown
Contributor Author

@jvmvik jvmvik Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to get 2.7 to work on github action is hard because the github plugin is buggy.

steps:
- uses: actions/checkout@v3
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand Down
Loading