Minor: improved logging

Author: grussorusso

internal/workflow/task_data.go

@@ -68,8 +68,7 @@ func (td *TaskData) Save(reqId ReqId, task TaskId) error {
 	}
 	// saves the json object into etcd
 	key := getTaskDataEtcdKey(reqId, task)
-	//log.Printf("Saving PD on etcd : %v\n", td.Data)
-	log.Printf("Saving PD on etcd with key: %s and payload: %v\n", key, string(payload))
+	log.Printf("Saving PD on etcd with key: %s\n", key)
 
 	_, err = cli.Put(ctx, key, string(payload))
 	if err != nil {
@@ -89,7 +88,7 @@ func RetrievePartialData(reqId ReqId, task TaskId) (*TaskData, error) {
 	log.Printf("Retrieving partial data with key: %s\n", key)
 	getResponse, err := cli.Get(ctx, key)
 	if err != nil {
-		return nil, fmt.Errorf("failed to retrieve partialDatas for requestId: %s", key)
+		return nil, fmt.Errorf("failed to retrieve PD for requestId %s: %v", key, err)
 	}
 	if len(getResponse.Kvs) > 1 {
 		return nil, fmt.Errorf("more than 1 TaskData associated with key: %s", key)

internal/workflow/workflow.go

@@ -500,17 +500,16 @@ func (wflow *Workflow) Invoke(r *Request) error {
 					}
 
 					if input != nil {
-						return fmt.Errorf("Merge of inputs not supported yet!")
+						return fmt.Errorf("merge of inputs not supported yet!")
 					}
 
 					input, found = dataMap[previousTask]
 					if !found {
 						log.Printf("Input not found in dataMap for previousTask %s", previousTask)
 						input, err = RetrievePartialData(requestId, previousTask)
 						if err != nil {
-							return fmt.Errorf("Could not retrieve partial data: %v", err)
+							return fmt.Errorf("could not retrieve partial data: %v", err)
 						}
-						log.Printf("Input retrieved from etcd: %s", input)
 					}
 				}
 			}