refactor(naming): introduce generateLogicalId factory method#762
Open
refactor(naming): introduce generateLogicalId factory method#762
Conversation
- Add generateLogicalId(name, suffix) to centralise the repeated getNormalizedFunctionName(name) + suffix pattern - Refactor 9 get*LogicalId methods to delegate to the factory - Add 2 tests for the new factory method (19/19 passing) Part of #708 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #758
Summary
generateLogicalId(name, suffix)factory tolib/naming.js, centralising the repeatedgetNormalizedFunctionName(name) + suffixpatternget*LogicalId()methods to delegate to the factory — public API unchanged, no callers affectedTest plan
get*LogicalId()methods require changesPart of #708
🤖 Generated with Claude Code