refactor(notifications): split compileNotifications into Strategy pattern#763
Open
refactor(notifications): split compileNotifications into Strategy pattern#763
Conversation
…tern - Add notificationStrategies/ directory with one module per target type (sns, sqs, kinesis, firehose, lambda, stepFunctions) - Each strategy exports compileTarget and compilePermission - Extract generateTargetId, generatePolicyName, buildInputOptions to utils.js - Replace if/else dispatch in compileNotifications.js with getStrategy() registry lookup - Add 17 unit tests covering each strategy's target and permission compilation Part of #759 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #759
Summary
notificationStrategies/with one module per target type (sns,sqs,kinesis,firehose,lambda,stepFunctions), each exportingcompileTargetandcompilePermission— mirroring the existingiamStrategies/patterngenerateTargetId,generatePolicyName,buildInputOptions) intoutils.jscompileNotifications.jswith a Map registry +getStrategy()lookupTest plan
compileNotificationsintegration tests passPart of #708
🤖 Generated with Claude Code