refactor(events): extract shared input validator and IAM role factory#764
Open
refactor(events): extract shared input validator and IAM role factory#764
Conversation
- Add lib/deploy/events/eventUtils.js with validateEventInput and buildIamRole - validateEventInput replaces duplicate if/else Input/InputPath/InputTransformer mutual-exclusivity checks in both schedule and cloudwatch event compilers - buildIamRole replaces duplicate JSON string IAM role templates, parameterised by principal service (events.amazonaws.com / scheduler.amazonaws.com) - Eliminates JSON.parse/stringify dance — IAM role mutations applied directly - Add 10 unit tests for both utilities Part of #760 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #760
Summary
eventUtils.jswithvalidateEventInput(replaces duplicate mutual-exclusivity checks in schedule and cloudwatch compilers) andbuildIamRole(replaces duplicate JSON string IAM role templates, parameterised by principal service)JSON.parse/stringifyround-trips — IAM role is now a plain JS object mutated directly forpermissionsBoundaryandrolePathTest plan
eventUtilsunit tests passPart of #708
🤖 Generated with Claude Code