Skip to content

Commit 3890ed6

Browse files
authored
Rename DSL.workflow to DSL.subflow (#1311)
* Rename DSL.workflow to DSL.subflow Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> * Add documentation about subflow Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com> --------- Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
1 parent 54c3752 commit 3890ed6

3 files changed

Lines changed: 20 additions & 4 deletions

File tree

  • fluent/spec/src
    • main/java/io/serverlessworkflow/fluent/spec/dsl
    • test/java/io/serverlessworkflow/fluent/spec/dsl
  • impl/test/src/test/java/io/serverlessworkflow/impl/test

fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/DSL.java

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,22 @@ public static TasksConfigurer call(CallOpenAPIConfigurer configurer) {
653653
return list -> list.openapi(configurer);
654654
}
655655

656-
public static TasksConfigurer workflow(WorkflowConfigurer configurer) {
656+
/**
657+
* Create a {@link TasksConfigurer} that adds a sub-workflow call task using a {@link
658+
* WorkflowConfigurer}.
659+
*
660+
* <p>
661+
*
662+
* <pre>{@code
663+
* tasks(
664+
* subflow(workflow("org.acme", "sub-workflow", "0.1.0").input(...)
665+
* );
666+
* }</pre>
667+
*
668+
* @param configurer
669+
* @return
670+
*/
671+
public static TasksConfigurer subflow(WorkflowConfigurer configurer) {
657672
return list -> list.workflow(configurer);
658673
}
659674

fluent/spec/src/test/java/io/serverlessworkflow/fluent/spec/dsl/DSLTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import static io.serverlessworkflow.fluent.spec.dsl.DSL.openapi;
2626
import static io.serverlessworkflow.fluent.spec.dsl.DSL.produced;
2727
import static io.serverlessworkflow.fluent.spec.dsl.DSL.secrets;
28+
import static io.serverlessworkflow.fluent.spec.dsl.DSL.subflow;
2829
import static io.serverlessworkflow.fluent.spec.dsl.DSL.to;
2930
import static io.serverlessworkflow.fluent.spec.dsl.DSL.workflow;
3031
import static org.assertj.core.api.Assertions.assertThat;
@@ -308,7 +309,7 @@ void when_dsl_subflow_workflow_task() {
308309
Workflow wf =
309310
WorkflowBuilder.workflow("parent", "ns", "1")
310311
.tasks(
311-
workflow(
312+
subflow(
312313
workflow("child.ns", "child-flow", "2.3.4")
313314
.input("id", 99)
314315
.await(false)
@@ -330,7 +331,7 @@ void when_dsl_subflow_workflow_task_with_map_input() {
330331
Workflow wf =
331332
WorkflowBuilder.workflow("parent", "ns", "1")
332333
.tasks(
333-
workflow(
334+
subflow(
334335
workflow("child.ns", "child-flow", "2.3.4")
335336
.input(Map.of("id", 7, "region", "eu"))
336337
.input("extra", true)

impl/test/src/test/java/io/serverlessworkflow/impl/test/SubWorkflowTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public void runSubWorkflowFromDslTest() throws Exception {
148148
Workflow parent =
149149
WorkflowBuilder.workflow("parentFlow", "org.acme", "1.0.0")
150150
.tasks(
151-
DSL.workflow(
151+
DSL.subflow(
152152
DSL.workflow("org.acme", "childFlow", "1.0.0")
153153
.input(Map.of("id", 42, "region", "us-east"))))
154154
.build();

0 commit comments

Comments
 (0)