Skip to content

Commit 83014f9

Browse files
committed
Guard against null parameter fields in OpenAPI operation parsing
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
1 parent cafd804 commit 83014f9

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/OperationDefinition.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ List<ParameterDefinition> getParameters() {
6060
List<ParameterDefinition> paramDefinitions = new ArrayList<>();
6161
if (operation.hasParameters()) {
6262
for (UnifiedOpenAPI.Parameter parameter : operation.parameters()) {
63-
if (parameter.in().equals("body")) {
63+
if (parameter.in() != null && parameter.in().equals("body")) {
6464
continue; // body parameters are handled separately
6565
}
6666

@@ -72,11 +72,11 @@ List<ParameterDefinition> getParameters() {
7272

7373
if (openAPI.swaggerVersion().equals(UnifiedOpenAPI.SwaggerVersion.SWAGGER_V2)) {
7474
operation.parameters().stream()
75-
.filter(p -> p.in().equals("body"))
75+
.filter(p -> p.in() != null && p.in().equals("body"))
7676
.forEach(
7777
p -> {
7878
UnifiedOpenAPI.Schema schema = p.schema();
79-
if (schema.hasRef()) {
79+
if (schema != null && schema.hasRef()) {
8080
String ref = schema.ref();
8181
schema = openAPI.resolveSchema(ref);
8282
}

impl/openapi/src/main/java/io/serverlessworkflow/impl/executors/openapi/UnifiedOpenAPI.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,11 @@ public boolean hasRequestBody() {
165165
}
166166
}
167167

168-
public record Parameter(String name, String in, Boolean required, Schema schema) {}
168+
public record Parameter(String name, String in, Boolean required, Schema schema) {
169+
public Parameter {
170+
required = required != null ? required : Boolean.FALSE;
171+
}
172+
}
169173

170174
public record RequestBody(Content content) {}
171175

0 commit comments

Comments
 (0)