Consider co-pilot comments

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>

Author: ricardozanini

impl/core/src/main/java/io/serverlessworkflow/impl/executors/WaitExecutor.java

@@ -42,14 +42,14 @@ public static class WaitExecutorBuilder extends RegularTaskExecutorBuilder<WaitT
     protected WaitExecutorBuilder(
         WorkflowMutablePosition position, WaitTask task, WorkflowDefinition definition) {
       super(position, task, definition);
-      if (task.getWait().getDurationExpression() == null) {
-        this.duration =
-            task.getWait().getDurationInline() != null
-                ? toDuration(task.getWait().getDurationInline())
-                : parseDurationLiteral(task.getWait().getDurationLiteral());
-      } else {
+      if (WorkflowUtils.isValid(task.getWait().getDurationExpression())) {
         this.durationExpressionFilter =
             WorkflowUtils.buildWorkflowFilter(application, task.getWait().getDurationExpression());
+      } else {
+        this.duration =
+            WorkflowUtils.isValid(task.getWait().getDurationLiteral())
+                ? parseDurationLiteral(task.getWait().getDurationLiteral())
+                : toDuration(task.getWait().getDurationInline());
       }
     }
 

impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java

@@ -20,6 +20,7 @@
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.awaitility.Awaitility.await;
 
+import io.serverlessworkflow.api.types.TimeoutAfter;
 import io.serverlessworkflow.api.types.Workflow;
 import io.serverlessworkflow.fluent.spec.WorkflowBuilder;
 import io.serverlessworkflow.fluent.spec.dsl.DSL;
@@ -106,22 +107,7 @@ void testWaitWithDurationLiteralISO8601Seconds() {
             .tasks(
                 list ->
                     list.wait(
-                        w ->
-                            w.build()
-                                .setWait(
-                                    new io.serverlessworkflow.api.types.TimeoutAfter()
-                                        .withDurationLiteral("PT1S"))))
-            .build();
-
-    long startTime = System.currentTimeMillis();
-    WorkflowModel model = appl.workflowDefinition(workflow).instance(Map.of()).start().join();
-    long elapsed = System.currentTimeMillis() - startTime;
-
-    assertThat(model).isNotNull();
-    assertThat(elapsed).isGreaterThanOrEqualTo(1000);
-  }
-        WorkflowBuilder.workflow("wait-literal-seconds", "test", "0.1.0")
-            .tasks(DSL.wait(Duration.parse("PT1S")))
+                        w -> w.build().setWait(new TimeoutAfter().withDurationExpression("PT1S"))))
             .build();
 
     long startTime = System.currentTimeMillis();
@@ -141,10 +127,7 @@ void testWaitWithDurationLiteralISO8601Composite() {
                 list ->
                     list.wait(
                         w ->
-                            w.build()
-                                .setWait(
-                                    new io.serverlessworkflow.api.types.TimeoutAfter()
-                                        .withDurationLiteral("PT1.5S"))))
+                            w.build().setWait(new TimeoutAfter().withDurationExpression("PT1.5S"))))
             .build();
 
     long startTime = System.currentTimeMillis();
@@ -164,10 +147,7 @@ void testWaitWithDurationLiteralISO8601Milliseconds() {
                 list ->
                     list.wait(
                         w ->
-                            w.build()
-                                .setWait(
-                                    new io.serverlessworkflow.api.types.TimeoutAfter()
-                                        .withDurationLiteral("PT0.1S"))))
+                            w.build().setWait(new TimeoutAfter().withDurationExpression("PT0.1S"))))
             .build();
 
     long startTime = System.currentTimeMillis();