Skip to content

Commit aab1365

Browse files
authored
Resolve some issues added by recents merges (#1210)
Signed-off-by: fjtirado <ftirados@redhat.com>
1 parent a1e3d37 commit aab1365

4 files changed

Lines changed: 24 additions & 31 deletions

File tree

impl/test/src/test/java/io/serverlessworkflow/impl/test/WorkflowNumberConversionTest.java renamed to experimental/lambda/src/test/java/io/serverless/workflow/impl/executors/func/WorkflowNumberConversionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package io.serverlessworkflow.impl.test;
16+
package io.serverless.workflow.impl.executors.func;
1717

1818
import static io.serverlessworkflow.fluent.func.dsl.FuncDSL.function;
1919

impl/test/src/test/java/io/serverlessworkflow/impl/test/WorkflowThenTest.java renamed to experimental/lambda/src/test/java/io/serverless/workflow/impl/executors/func/WorkflowThenTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package io.serverlessworkflow.impl.test;
16+
package io.serverless.workflow.impl.executors.func;
1717

1818
import static io.serverlessworkflow.fluent.func.dsl.FuncDSL.consume;
1919
import static io.serverlessworkflow.fluent.func.dsl.FuncDSL.function;

experimental/model/src/main/java/io/serverlessworkflow/impl/model/func/JavaModel.java

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -68,24 +68,29 @@ public Optional<Number> asNumber() {
6868

6969
@Override
7070
protected <N extends Number> Optional<N> asNumber(Class<N> targetNumberClass) {
71-
if (!(object instanceof Number num)) {
72-
return Optional.empty();
73-
}
74-
if (targetNumberClass == Integer.class || targetNumberClass == BigInteger.class) {
75-
return Optional.of(targetNumberClass.cast(num.intValue()));
76-
} else if (targetNumberClass == Long.class) {
77-
return Optional.of(targetNumberClass.cast(num.longValue()));
78-
} else if (targetNumberClass == Double.class || targetNumberClass == BigDecimal.class) {
79-
return Optional.of(targetNumberClass.cast(num.doubleValue()));
80-
} else if (targetNumberClass == Float.class) {
81-
return Optional.of(targetNumberClass.cast(num.floatValue()));
82-
} else if (targetNumberClass == Short.class) {
83-
return Optional.of(targetNumberClass.cast(num.shortValue()));
84-
} else if (targetNumberClass == Byte.class) {
85-
return Optional.of(targetNumberClass.cast(num.byteValue()));
86-
} else {
87-
return Optional.of(targetNumberClass.cast(num));
71+
72+
if (object instanceof Number num) {
73+
if (targetNumberClass.isInstance(object)) {
74+
return Optional.of(targetNumberClass.cast(object));
75+
} else if (targetNumberClass == Integer.class) {
76+
return Optional.of(targetNumberClass.cast(num.intValue()));
77+
} else if (targetNumberClass == Long.class) {
78+
return Optional.of(targetNumberClass.cast(num.longValue()));
79+
} else if (targetNumberClass == Double.class) {
80+
return Optional.of(targetNumberClass.cast(num.doubleValue()));
81+
} else if (targetNumberClass == Float.class) {
82+
return Optional.of(targetNumberClass.cast(num.floatValue()));
83+
} else if (targetNumberClass == Short.class) {
84+
return Optional.of(targetNumberClass.cast(num.shortValue()));
85+
} else if (targetNumberClass == Byte.class) {
86+
return Optional.of(targetNumberClass.cast(num.byteValue()));
87+
} else if (targetNumberClass == BigDecimal.class) {
88+
return Optional.of(targetNumberClass.cast(BigDecimal.valueOf(num.doubleValue())));
89+
} else if (targetNumberClass == BigInteger.class) {
90+
return Optional.of(targetNumberClass.cast(BigInteger.valueOf(num.longValue())));
91+
}
8892
}
93+
return Optional.empty();
8994
}
9095

9196
@Override

impl/test/pom.xml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -94,18 +94,6 @@
9494
<artifactId>grpc-netty</artifactId>
9595
<scope>test</scope>
9696
</dependency>
97-
<dependency>
98-
<groupId>io.serverlessworkflow</groupId>
99-
<artifactId>serverlessworkflow-experimental-fluent-func</artifactId>
100-
<scope>test</scope>
101-
<version>${project.version}</version>
102-
</dependency>
103-
<dependency>
104-
<groupId>io.serverlessworkflow</groupId>
105-
<artifactId>serverlessworkflow-experimental-lambda</artifactId>
106-
<scope>test</scope>
107-
<version>${project.version}</version>
108-
</dependency>
10997
</dependencies>
11098
<build>
11199
<resources>

0 commit comments

Comments
 (0)