Consider co-pilot review

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>

Author: ricardozanini

impl/core/src/main/java/io/serverlessworkflow/impl/executors/WaitExecutor.java

@@ -105,25 +105,22 @@ protected CompletableFuture<WorkflowModel> internalExecute(
   }
 
   private Duration evaluateDurationExpression(WorkflowContext workflow, TaskContext taskContext) {
-    String durationString =
-        durationExpressionFilter
-            .apply(workflow, taskContext, taskContext.rawInput())
-            .as(String.class)
-            .orElse(null);
+    final Object durationObject =
+        durationExpressionFilter.apply(workflow, taskContext, taskContext.input()).asJavaObject();
 
-    if (!WorkflowUtils.isValid(durationString)) {
+    if (durationObject == null || !WorkflowUtils.isValid(durationObject.toString())) {
       throw new IllegalArgumentException(
           "Wait duration expression evaluated to empty or null at task: "
               + taskContext.position().jsonPointer()
               + ". Expression must return a valid ISO 8601 duration string.");
     }
 
     try {
-      return Duration.parse(durationString.trim());
+      return Duration.parse(durationObject.toString().trim());
     } catch (Exception e) {
       throw new IllegalArgumentException(
           "Wait duration expression returned invalid ISO 8601 duration '"
-              + durationString
+              + durationObject
               + "' at task: "
               + taskContext.position().jsonPointer()
               + ". Expected format: PT[n]H[n]M[n]S (e.g., PT1H30M, PT5S)",

impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java

@@ -195,7 +195,7 @@ void testWaitWithDurationExpressionMissingValue() throws IOException {
     // message
     assertThatThrownBy(() -> appl.workflowDefinition(workflow).instance(Map.of()).start().join())
         .hasCauseInstanceOf(IllegalArgumentException.class)
-        .hasMessageContaining("duration 'null'");
+        .hasMessageContaining("evaluated to empty or null");
   }
 
   // ========== Workflow Status Tests ==========
@@ -204,7 +204,7 @@ void testWaitWithDurationExpressionMissingValue() throws IOException {
   void testWaitSetsWorkflowStatusToWaiting() {
     Workflow workflow =
         WorkflowBuilder.workflow("wait-status-waiting", "test", "0.1.0")
-            .tasks(DSL.waitSeconds(2))
+            .tasks(DSL.waitMillis(500))
             .build();
 
     WorkflowInstance instance = appl.workflowDefinition(workflow).instance(Map.of());
@@ -225,7 +225,7 @@ void testWaitSetsWorkflowStatusToWaiting() {
   void testWaitWithSuspendAndResume() {
     Workflow workflow =
         WorkflowBuilder.workflow("wait-suspend-resume", "test", "0.1.0")
-            .tasks(DSL.waitSeconds(2))
+            .tasks(DSL.waitMillis(500))
             .build();
 
     WorkflowInstance instance = appl.workflowDefinition(workflow).instance(Map.of());
@@ -263,12 +263,9 @@ void testWaitSecondsConvenienceMethod() {
             .tasks(DSL.waitSeconds(1))
             .build();
 
-    long startTime = System.currentTimeMillis();
-    WorkflowModel model = appl.workflowDefinition(workflow).instance(Map.of()).start().join();
-    long elapsed = System.currentTimeMillis() - startTime;
-
-    assertThat(model).isNotNull();
-    assertThat(elapsed).isGreaterThanOrEqualTo(1000);
+    var waitTask = workflow.getDo().get(0).getTask().getWaitTask();
+    assertThat(waitTask).isNotNull();
+    assertThat(waitTask.getWait().getDurationInline().getSeconds()).isEqualTo(1);
   }
 
   @Test
@@ -278,12 +275,9 @@ void testWaitMillisConvenienceMethod() {
             .tasks(DSL.waitMillis(100))
             .build();
 
-    long startTime = System.currentTimeMillis();
-    WorkflowModel model = appl.workflowDefinition(workflow).instance(Map.of()).start().join();
-    long elapsed = System.currentTimeMillis() - startTime;
-
-    assertThat(model).isNotNull();
-    assertThat(elapsed).isGreaterThanOrEqualTo(100);
+    var waitTask = workflow.getDo().get(0).getTask().getWaitTask();
+    assertThat(waitTask).isNotNull();
+    assertThat(waitTask.getWait().getDurationInline().getMilliseconds()).isEqualTo(100);
   }
 
   @Test
@@ -293,11 +287,10 @@ void testWaitWithJavaDurationConvenienceMethod() {
             .tasks(DSL.wait(Duration.ofSeconds(1).plusMillis(500)))
             .build();
 
-    long startTime = System.currentTimeMillis();
-    WorkflowModel model = appl.workflowDefinition(workflow).instance(Map.of()).start().join();
-    long elapsed = System.currentTimeMillis() - startTime;
-
-    assertThat(model).isNotNull();
-    assertThat(elapsed).isGreaterThanOrEqualTo(1500);
+    var waitTask = workflow.getDo().get(0).getTask().getWaitTask();
+    assertThat(waitTask).isNotNull();
+    var inline = waitTask.getWait().getDurationInline();
+    assertThat(inline.getSeconds()).isEqualTo(1);
+    assertThat(inline.getMilliseconds()).isEqualTo(500);
   }
 }