Improve cloud event to json conversion#1445
Merged
fjtirado merged 1 commit intoJun 10, 2026
Merged
Conversation
Relies on SDK serialization/deserialization. Adds small patch to be compliant with expected behaviour Signed-off-by: fjtirado <ftirados@ibm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CloudEvent ↔ JSON conversion to rely on the project’s configured Jackson ObjectMapper (including the CloudEvents Jackson module) rather than using the CloudEvents SDK EventFormatProvider JSON format directly, with an additional adjustment to ensure the data envelope is represented as JSON when needed.
Changes:
- Reworked
JacksonCloudEventUtils.toJsonNode(CloudEvent)to useObjectMapper.convertValue(...)and normalizedatawhen it is emitted as aPOJONode. - Reworked
JacksonCloudEventUtils.toCloudEvent(JsonNode)to useObjectMapper.convertValue(...)for deserialization. - Expanded unit tests to cover CloudEvent serialization with
nulldata and withJsonCloudEventData.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| impl/json-utils/src/main/java/io/serverlessworkflow/impl/jackson/JacksonCloudEventUtils.java | Switches CloudEvent JSON conversion to Jackson convertValue and adjusts data node handling. |
| impl/json-utils/src/test/java/io/serverlessworkflow/impl/jackson/JacksonCloudEventUtilsTest.java | Adds/updates tests for null data serialization and JsonCloudEventData serialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ricardozanini
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on SDK serialization/deserialization.
Adds small patch to be compliant with expected behaviour