Skip to content

Commit a0c37dc

Browse files
committed
fix error handling when syncing lb status
1 parent 2f8d1f5 commit a0c37dc

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

internal/service/service.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,10 @@ func (s *Service) SyncToPortal(key string) error {
122122
ctx, cancel := context.WithTimeout(context.Background(), LBPollTimeout)
123123
defer cancel()
124124
activeLB, err := s.syncManager.SyncStatus(ctx, lb)
125+
if err != nil {
126+
s.recorder.Eventf(ing, v1.EventTypeWarning, "SyncStatus", err.Error())
127+
return
128+
}
125129

126130
var ingress []networkv1.IngressLoadBalancerIngress
127131
for _, ip := range activeLB.ExternalAddresses {
@@ -134,9 +138,10 @@ func (s *Service) SyncToPortal(key string) error {
134138
},
135139
}
136140
ingClient := s.KubeClient.NetworkingV1().Ingresses(ing.Namespace)
137-
_, err = ingClient.UpdateStatus(context.Background(), ing, metav1.UpdateOptions{})
141+
_, err = ingClient.UpdateStatus(ctx, ing, metav1.UpdateOptions{})
138142
if err != nil {
139143
s.recorder.Eventf(ing, v1.EventTypeWarning, "UpdateStatus", err.Error())
144+
return
140145
}
141146

142147
s.recorder.Eventf(ing, v1.EventTypeNormal, "Synced", "Successfully synced")

0 commit comments

Comments
 (0)