impl jsstr_to_string and latin1_to_string using &JSContext#718
Open
sagudev wants to merge 4 commits into
Open
Conversation
jschwe
reviewed
Mar 15, 2026
| /// `String`. | ||
| /// | ||
| /// Use [`latin1_to_string_safe`] if possible as this function will be eventually removed. | ||
| pub unsafe fn latin1_to_string(cx: *mut JSContext, s: NonNull<JSString>) -> String { |
Member
There was a problem hiding this comment.
Should we perhaps add a deprecated annotation on it, or call it _legacy to make the comment about "will eventually be removed" more obvious at the usage sites?
Member
Author
There was a problem hiding this comment.
The way we are currently doing is just adding comments without renames/deprecation notice for less friction in servo. But eventually we should start doing this.
Contributor
There was a problem hiding this comment.
There are only a couple of places left where we can't switch to the safe version yet; so with a companion pr that migrates the other instances to the safe version, we can start deprecating the unsafe one.
Member
Author
There was a problem hiding this comment.
I did this now, but I do not have time for companion PR.
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Change is covered by existing tests.