fix: validate SOGS attachment sizes#1954
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
MikeScanlan5
approved these changes
Jun 18, 2026
MikeScanlan5
left a comment
There was a problem hiding this comment.
Code looks clear and fixes the intended attachment size issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
devbranchDescription
Refs #1953
This hardens SOGS attachment downloads by requiring message attachments to include an expected size before they are accepted as successful downloads
Community avatar downloads still opt into unknown-size payloads explicitly, since that path does not get size metadata
Tests:
corepack pnpm exec tsccorepack pnpm exec eslint --cache .corepack pnpm exec cross-env IS_UNIT_TEST=1 mochacorepack pnpm dedupe --checkcorepack pnpm build:protobufcorepack pnpm build:sasscorepack pnpm build:svgcorepack pnpm worker:utilscorepack pnpm worker:libsessioncorepack pnpm worker:image_processor